Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate post-processing of SamplerV1 results and ExactSampler #551

Open
garrison opened this issue Apr 16, 2024 · 3 comments
Open

Deprecate post-processing of SamplerV1 results and ExactSampler #551

garrison opened this issue Apr 16, 2024 · 3 comments
Labels
cutting QPD-based circuit cutting code
Milestone
0.10.0

Comments

@garrison
Copy link
Member

Following the primitives v1 deprecation in qiskit-ibm-runtime: Qiskit/qiskit-ibm-runtime#1591
@garrison garrison added the cutting QPD-based circuit cutting code label Apr 16, 2024
@garrison garrison added this to the 0.8.0 milestone Apr 16, 2024
@garrison
Copy link
Member Author

Related to #506.

@garrison
Copy link
Member Author

Primitives v1 is also scheduled to be deprecated in Qiskit 1.2 currently: Qiskit/qiskit#12575

garrison added a commit that referenced this issue Aug 2, 2024
@garrison
Use BaseSamplerV1 with explicit version
8aff490 
This change is motivated by the following warning:

> DeprecationWarning: The class ``qiskit.primitives.base.base_sampler.BaseSampler``
> is deprecated as of qiskit 1.2. It will be removed no earlier
> than 3 months after the release date. The `BaseSampler` class is
> a type alias for the `BaseSamplerV1` interface that has been
> deprecated in favor of explicitly versioned interface classes.
> It is recommended to migrate all implementations to use
> `BaseSamplerV2`. However, for implementations incompatible with
> `BaseSamplerV2`, `BaseSampler` can be replaced with the explicitly
> versioned `BaseSamplerV1` class.

Related to #551 and #506.
@garrison garrison mentioned this issue Aug 2, 2024
Merged
garrison added a commit that referenced this issue Aug 2, 2024
@garrison
Use BaseSamplerV1 with explicit version (#653)
a9bfc91 
This change is motivated by the following warning:

> DeprecationWarning: The class ``qiskit.primitives.base.base_sampler.BaseSampler``
> is deprecated as of qiskit 1.2. It will be removed no earlier
> than 3 months after the release date. The `BaseSampler` class is
> a type alias for the `BaseSamplerV1` interface that has been
> deprecated in favor of explicitly versioned interface classes.
> It is recommended to migrate all implementations to use
> `BaseSamplerV2`. However, for implementations incompatible with
> `BaseSamplerV2`, `BaseSampler` can be replaced with the explicitly
> versioned `BaseSamplerV1` class.

Related to #551 and #506.
mergify bot pushed a commit that referenced this issue Aug 2, 2024
@garrison @mergify
Use BaseSamplerV1 with explicit version (#653)
51b6d64 
This change is motivated by the following warning:

> DeprecationWarning: The class ``qiskit.primitives.base.base_sampler.BaseSampler``
> is deprecated as of qiskit 1.2. It will be removed no earlier
> than 3 months after the release date. The `BaseSampler` class is
> a type alias for the `BaseSamplerV1` interface that has been
> deprecated in favor of explicitly versioned interface classes.
> It is recommended to migrate all implementations to use
> `BaseSamplerV2`. However, for implementations incompatible with
> `BaseSamplerV2`, `BaseSampler` can be replaced with the explicitly
> versioned `BaseSamplerV1` class.

Related to #551 and #506.

(cherry picked from commit a9bfc91)
@mergify mergify bot mentioned this issue Aug 2, 2024
Merged
garrison added a commit that referenced this issue Aug 2, 2024
@mergify @garrison
Use BaseSamplerV1 with explicit version (#653) (#654)
f0f7897 
This change is motivated by the following warning:

> DeprecationWarning: The class ``qiskit.primitives.base.base_sampler.BaseSampler``
> is deprecated as of qiskit 1.2. It will be removed no earlier
> than 3 months after the release date. The `BaseSampler` class is
> a type alias for the `BaseSamplerV1` interface that has been
> deprecated in favor of explicitly versioned interface classes.
> It is recommended to migrate all implementations to use
> `BaseSamplerV2`. However, for implementations incompatible with
> `BaseSamplerV2`, `BaseSampler` can be replaced with the explicitly
> versioned `BaseSamplerV1` class.

Related to #551 and #506.

(cherry picked from commit a9bfc91)

Co-authored-by: Jim Garrison <garrison@ibm.com>
@garrison
Copy link
Member Author

So far, BaseSamplerV1 is still safe and not deprecated.

@garrison garrison modified the milestones: 0.9.0, 0.10.0 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cutting QPD-based circuit cutting code
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@garrison