Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BaseSamplerV1 with explicit version #653

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

garrison
Copy link
Member

@garrison garrison commented Aug 2, 2024

This change is motivated by the following warning under the Qiskit 1.2 rc:

DeprecationWarning: The class qiskit.primitives.base.base_sampler.BaseSampler is deprecated as of qiskit 1.2. It will be removed no earlier than 3 months after the release date. The BaseSampler class is a type alias for the BaseSamplerV1 interface that has been deprecated in favor of explicitly versioned interface classes. It is recommended to migrate all implementations to use BaseSamplerV2. However, for implementations incompatible with BaseSamplerV2, BaseSampler can be replaced with the explicitly versioned BaseSamplerV1 class.

Related to #551 and #506.

This change is motivated by the following warning:

> DeprecationWarning: The class ``qiskit.primitives.base.base_sampler.BaseSampler``
> is deprecated as of qiskit 1.2. It will be removed no earlier
> than 3 months after the release date. The `BaseSampler` class is
> a type alias for the `BaseSamplerV1` interface that has been
> deprecated in favor of explicitly versioned interface classes.
> It is recommended to migrate all implementations to use
> `BaseSamplerV2`. However, for implementations incompatible with
> `BaseSamplerV2`, `BaseSampler` can be replaced with the explicitly
> versioned `BaseSamplerV1` class.

Related to #551 and #506.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10218803277

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10208185096: 0.0%
Covered Lines: 2410
Relevant Lines: 2410

💛 - Coveralls

@garrison garrison added the stable backport potential Suitable to be backported to most recent stable branch by Mergify label Aug 2, 2024
@garrison garrison marked this pull request as ready for review August 2, 2024 16:34
@garrison garrison merged commit a9bfc91 into main Aug 2, 2024
11 checks passed
@garrison garrison deleted the basesampler-explicit-v1 branch August 2, 2024 16:35
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
This change is motivated by the following warning:

> DeprecationWarning: The class ``qiskit.primitives.base.base_sampler.BaseSampler``
> is deprecated as of qiskit 1.2. It will be removed no earlier
> than 3 months after the release date. The `BaseSampler` class is
> a type alias for the `BaseSamplerV1` interface that has been
> deprecated in favor of explicitly versioned interface classes.
> It is recommended to migrate all implementations to use
> `BaseSamplerV2`. However, for implementations incompatible with
> `BaseSamplerV2`, `BaseSampler` can be replaced with the explicitly
> versioned `BaseSamplerV1` class.

Related to #551 and #506.

(cherry picked from commit a9bfc91)
garrison added a commit that referenced this pull request Aug 2, 2024
This change is motivated by the following warning:

> DeprecationWarning: The class ``qiskit.primitives.base.base_sampler.BaseSampler``
> is deprecated as of qiskit 1.2. It will be removed no earlier
> than 3 months after the release date. The `BaseSampler` class is
> a type alias for the `BaseSamplerV1` interface that has been
> deprecated in favor of explicitly versioned interface classes.
> It is recommended to migrate all implementations to use
> `BaseSamplerV2`. However, for implementations incompatible with
> `BaseSamplerV2`, `BaseSampler` can be replaced with the explicitly
> versioned `BaseSamplerV1` class.

Related to #551 and #506.

(cherry picked from commit a9bfc91)

Co-authored-by: Jim Garrison <garrison@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable backport potential Suitable to be backported to most recent stable branch by Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants