-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noise transformation fails with the latest cvxpy version #779
Comments
Version 1.1.0 of cvxpy was released yesterday and is causing tests to fail. It's not clear if this is a bug in the noise transformation code or in cvxpy. But until this is resolved (see Qiskit#779) this adds a version cap to the dev requirements list to avoid the version which fails.
Version 1.1.0 of cvxpy was released yesterday and is causing tests to fail. It's not clear if this is a bug in the noise transformation code or in cvxpy. But until this is resolved (see #779) this adds a version cap to the dev requirements list to avoid the version which fails.
It looks like cvxpy 1.1.0 was just released with a regression which caused the test failures. A day after 1.1.0 was released and Qiskit#780 was merged in aer to cap cvxpy 1.1.1 was pushed out without any issues or PRs opened or without any release notes published. Looking at the git log there was 1 commit on top of 1.1.0 for the 1.1.1 release [1] which looks releated to the error message we were seeing with 1.1.0. This commit removes the version cap to try (and changes it to exclude 1.1.0 only) to see if 1.1.1 fixes our problem. Potentially Fixes Qiskit#779 [1] cvxgrp/cvxpy@1ea3d67
It looks like 1.1.1 did not fix the failure so we'll still have to keep the cap. It looks like other people are seeing this too: https://github.com/cvxgrp/cvxpy/issues/1051 so it's probably not an aer bug. But let's keep this open to track the cap |
Would you like the cvxpy devs to look at this? My guess is there's an issue with mixed eigenvalues. |
@SteveDiamond yeah that would be great. I haven't found the time to dig into it myself |
I can simplify the problem a little. The following optimization fails because of non-DCP:
|
Until we understand what's going on in CVXPY, I'm removing the test (in #832). I tried debugging my code but could not find any concrete problem with it. |
@gadial the problem solves fine with the master branch of cvxpy. I also pushed a new version with the fix. |
Since the release of cvxpy 1.1.3 the issue reported in #779 which was caused the Clifford-based transformations has been addressed. This commit removes the version cap to enable the use of the latest versions of cvxpy again. * Removing a test which crashes due to changes in CVXPY * Style * Return simplified test version * Removed version pin
The bug in cvxpy 1.1.x that was breaking the aqua usage has been fixed in the latest 1.1.3 release (see Qiskit/qiskit-aer#832 and Qiskit/qiskit-aer#779 for more details). Since the bug is fixed we can remove the version cap an enable newer versions of cvxpy to be installed. Exclude rules are left on the setuptools extra requirement so that end users don't accidently try to use a version known not to run.
The bug in cvxpy 1.1.x that was breaking the aqua usage has been fixed in the latest 1.1.3 release (see Qiskit/qiskit-aer#832 and Qiskit/qiskit-aer#779 for more details). Since the bug is fixed we can remove the version cap an enable newer versions of cvxpy to be installed. Exclude rules are left on the setuptools extra requirement so that end users don't accidently try to use a version known not to run. Co-authored-by: Manoel Marques <manoelmrqs@gmail.com>
The bug in cvxpy 1.1.x that was breaking the aqua usage has been fixed in the latest 1.1.3 release (see Qiskit/qiskit-aer#832 and Qiskit/qiskit-aer#779 for more details). Since the bug is fixed we can remove the version cap an enable newer versions of cvxpy to be installed. Exclude rules are left on the setuptools extra requirement so that end users don't accidently try to use a version known not to run. Co-authored-by: Manoel Marques <manoelmrqs@gmail.com>
Informations
What is the current behavior?
Running tests with cvxpy 1.1.0 installed fails:
https://travis-ci.com/github/Qiskit/qiskit-aer/jobs/342857594#L14782
Steps to reproduce the problem
What is the expected behavior?
They pass
Suggested solutions
Find underlying cause of the failure and open a bug on cvxpy if necessary.
The text was updated successfully, but these errors were encountered: