Remove cvxpy cap and exclude broken version #791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like cvxpy 1.1.0 was just released with a regression which caused the test failures. A day after 1.1.0 was released and Qiskit#780 was merged in aer to cap cvxpy 1.1.1 was pushed out without any issues or PRs opened or without any release notes published. Looking at the git log there was 1 commit on top of 1.1.0 for the 1.1.1 release [1] which looks releated to the error message we were seeing with 1.1.0. This commit removes the version cap to try (and changes it to exclude 1.1.0 only) to see if 1.1.1 fixes our problem. Potentially Fixes Qiskit#779 [1] cvxgrp/cvxpy@1ea3d67
|
nope, this didn't fix it: https://travis-ci.com/github/Qiskit/qiskit-aer/jobs/347604824#L14795 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It looks like cvxpy 1.1.0 was just released with a regression which
caused the test failures. A day after 1.1.0 was released and #780 was
merged in aer to cap cvxpy 1.1.1 was pushed out without any issues
or PRs opened or without any release notes published. Looking at the git
log there was 1 commit on top of 1.1.0 for the 1.1.1 release [1] which
looks releated to the error message we were seeing with 1.1.0. This
commit removes the version cap to try (and changes it to exclude 1.1.0
only) to see if 1.1.1 fixes our problem.
Details and comments
Potentially Fixes #779
[1] cvxgrp/cvxpy@1ea3d67