Add Python 3.9 support #1071
Merged
Add Python 3.9 support #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds official python 3.9 support to qiskit-aer. This includes CI, release notes, and package metadata. Fixes Qiskit#1067
mtreinish
requested review from
atilag,
chriseclectic and
vvilpas
as code owners
|
It looks like python 3.9 builds work fine (and passes verify wheels), but there are some CI issues for the tests jobs around cvxpy and related on python 3.9 that are blocking those jobs. |
The assertNoLogs methods was built using a private class from python's stdlib unittest library. This should never have been done as it's explicitly marked as private. Accordingly in Python 3.9 this private class has been removed and no longer exists. It turns out this method was not used anywhere in all of qiskit (the same identical code was removed from terra as part of Qiskit/qiskit#5189 in Qiskit/qiskit@ed5155b). Since the implementation is not sound and nothing uses it this commit just removes the class and method.
|
One thing to note here is that since #1074 we're not trying to test the noise transformations on Python 3.9 anymore as we're no longer installing cvxpy outside of python 3.7 and 3.8. There were issues installing cvxpy because of scs with 3.9. I'm thinking we should document this in the release notes. |
vvilpas
suggested changes
Dec 10, 2020
azure-pipelines.yml
Outdated
| @@ -140,6 +140,8 @@ stages: | |||
| python.version: '3.7' | |||
| Python38: | |||
| python.version: '3.8' | |||
| Python38: | |||
There was a problem hiding this comment.
Suggested change
| Python38: | |
| Python39: |
There was a problem hiding this comment.
I fixed this issue yesterday to unblock the azure runs: bb99ae1 I think you might have been looking at a stale diff.
azure-pipelines.yml
Outdated
| @@ -229,6 +231,8 @@ stages: | |||
| python.version: '3.7' | |||
| Python38: | |||
| python.version: '3.8' | |||
| Python38: | |||
There was a problem hiding this comment.
Suggested change
| Python38: | |
| Python39: |
vvilpas
approved these changes
Dec 10, 2020
mtreinish
added a commit
to mtreinish/aqua
that referenced
this pull request
Jan 14, 2021
Python 3.9.0 was released on 10-05-2020, this commits marks the support of Python 3.9 in qiskit-ignis. It adds the supported python version in the package metadata and updates the CI configuration to run test jobs on Python 3.9. This follows on from Qiskit/qiskit#5189, qiskit-community/qiskit-ignis#505, and Qiskit/qiskit-aer#1071
mtreinish
added a commit
to mtreinish/aqua
that referenced
this pull request
Jan 14, 2021
Python 3.9.0 was released on 10-05-2020, this commits marks the support of Python 3.9 in qiskit-aqua. It adds the supported python version in the package metadata and updates the CI configuration to run test jobs on Python 3.9. This follows on from Qiskit/qiskit#5189, qiskit-community/qiskit-ignis#505, and Qiskit/qiskit-aer#1071
manoelmarques
pushed a commit
to qiskit-community/qiskit-aqua
that referenced
this pull request
Jan 15, 2021
* Add support for Python 3.9 Python 3.9.0 was released on 10-05-2020, this commits marks the support of Python 3.9 in qiskit-aqua. It adds the supported python version in the package metadata and updates the CI configuration to run test jobs on Python 3.9. This follows on from Qiskit/qiskit#5189, qiskit-community/qiskit-ignis#505, and Qiskit/qiskit-aer#1071 * Add release note * Remove 3.9 tutorial job Jupyter on 3.9 doesn't have a good story yet, so just run tutorials on 3.6 and 3.8 for now. * Update optional requirement system constraints Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
chriseclectic
added
the
stable-backport-potential
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
* Add Python 3.9 support This commit adds official python 3.9 support to qiskit-aer. This includes CI, release notes, and package metadata. Fixes Qiskit#1067 * Remove wheel job 3.9 skip * Remove unused assertNoLogs method The assertNoLogs methods was built using a private class from python's stdlib unittest library. This should never have been done as it's explicitly marked as private. Accordingly in Python 3.9 this private class has been removed and no longer exists. It turns out this method was not used anywhere in all of qiskit (the same identical code was removed from terra as part of Qiskit/qiskit#5189 in Qiskit/qiskit@ed5155b). Since the implementation is not sound and nothing uses it this commit just removes the class and method. * Fix azure pipelines job matrix typo Co-authored-by: Victor Villar <vvilpas@gmail.com>
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
* Add Python 3.9 support This commit adds official python 3.9 support to qiskit-aer. This includes CI, release notes, and package metadata. Fixes Qiskit#1067 * Remove wheel job 3.9 skip * Remove unused assertNoLogs method The assertNoLogs methods was built using a private class from python's stdlib unittest library. This should never have been done as it's explicitly marked as private. Accordingly in Python 3.9 this private class has been removed and no longer exists. It turns out this method was not used anywhere in all of qiskit (the same identical code was removed from terra as part of Qiskit/qiskit#5189 in Qiskit/qiskit@ed5155b). Since the implementation is not sound and nothing uses it this commit just removes the class and method. * Fix azure pipelines job matrix typo Co-authored-by: Victor Villar <vvilpas@gmail.com>
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
* Add Python 3.9 support This commit adds official python 3.9 support to qiskit-aer. This includes CI, release notes, and package metadata. Fixes Qiskit#1067 * Remove wheel job 3.9 skip * Remove unused assertNoLogs method The assertNoLogs methods was built using a private class from python's stdlib unittest library. This should never have been done as it's explicitly marked as private. Accordingly in Python 3.9 this private class has been removed and no longer exists. It turns out this method was not used anywhere in all of qiskit (the same identical code was removed from terra as part of Qiskit/qiskit#5189 in Qiskit/qiskit@ed5155b). Since the implementation is not sound and nothing uses it this commit just removes the class and method. * Fix azure pipelines job matrix typo Co-authored-by: Victor Villar <vvilpas@gmail.com>
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
* Add Python 3.9 support This commit adds official python 3.9 support to qiskit-aer. This includes CI, release notes, and package metadata. Fixes Qiskit#1067 * Remove wheel job 3.9 skip * Remove unused assertNoLogs method The assertNoLogs methods was built using a private class from python's stdlib unittest library. This should never have been done as it's explicitly marked as private. Accordingly in Python 3.9 this private class has been removed and no longer exists. It turns out this method was not used anywhere in all of qiskit (the same identical code was removed from terra as part of Qiskit/qiskit#5189 in Qiskit/qiskit@ed5155b). Since the implementation is not sound and nothing uses it this commit just removes the class and method. * Fix azure pipelines job matrix typo Co-authored-by: Victor Villar <vvilpas@gmail.com>
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
* Add Python 3.9 support This commit adds official python 3.9 support to qiskit-aer. This includes CI, release notes, and package metadata. Fixes Qiskit#1067 * Remove wheel job 3.9 skip * Remove unused assertNoLogs method The assertNoLogs methods was built using a private class from python's stdlib unittest library. This should never have been done as it's explicitly marked as private. Accordingly in Python 3.9 this private class has been removed and no longer exists. It turns out this method was not used anywhere in all of qiskit (the same identical code was removed from terra as part of Qiskit/qiskit#5189 in Qiskit/qiskit@ed5155b). Since the implementation is not sound and nothing uses it this commit just removes the class and method. * Fix azure pipelines job matrix typo Co-authored-by: Victor Villar <vvilpas@gmail.com>
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
* Add Python 3.9 support This commit adds official python 3.9 support to qiskit-aer. This includes CI, release notes, and package metadata. Fixes Qiskit#1067 * Remove wheel job 3.9 skip * Remove unused assertNoLogs method The assertNoLogs methods was built using a private class from python's stdlib unittest library. This should never have been done as it's explicitly marked as private. Accordingly in Python 3.9 this private class has been removed and no longer exists. It turns out this method was not used anywhere in all of qiskit (the same identical code was removed from terra as part of Qiskit/qiskit#5189 in Qiskit/qiskit@ed5155b). Since the implementation is not sound and nothing uses it this commit just removes the class and method. * Fix azure pipelines job matrix typo Co-authored-by: Victor Villar <vvilpas@gmail.com>
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
* Add Python 3.9 support This commit adds official python 3.9 support to qiskit-aer. This includes CI, release notes, and package metadata. Fixes Qiskit#1067 * Remove wheel job 3.9 skip * Remove unused assertNoLogs method The assertNoLogs methods was built using a private class from python's stdlib unittest library. This should never have been done as it's explicitly marked as private. Accordingly in Python 3.9 this private class has been removed and no longer exists. It turns out this method was not used anywhere in all of qiskit (the same identical code was removed from terra as part of Qiskit/qiskit#5189 in Qiskit/qiskit@ed5155b). Since the implementation is not sound and nothing uses it this commit just removes the class and method. * Fix azure pipelines job matrix typo Co-authored-by: Victor Villar <vvilpas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds official python 3.9 support to qiskit-aer. This
includes CI, release notes, and package metadata.
Details and comments
Fixes #1067
Upstream dependencies that need Python 3.9 support:
- [ ] osqp(sidestepped by skipping cvxpy tests for py39)