Restrict cvxpy testing to python 3.7 and 3.8 #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cvxpy packaging (more specifically scs) is causing issues in CI for us because since it is incorrectly trying to install numpy from a pre-release package which does not support python 3.6. The nature of this issue is difficult to pin because it's not using pip to install numpy. Since cvxpy is only used in a single place, noise transformations, instead of trying to workaround these scs packaging issues this commit just restricts the test requirements on cvxpy to only match pytho 3.7 or 3.8. If cvxpy is not installed the noise transformation tests will now skip instead of fail.
mtreinish
requested review from
atilag,
chriseclectic and
vvilpas
as code owners
The tutorials repo has added some new types of tutorials for different parts of aqua. These should be skipped since they don't really exercise the aer api. This commit updates the tutorials job definition to stop running these new tutorials.
|
This is working except for some pulse simulator test failures that look like they were probably caused by Qiskit/qiskit#5481 |
Delay instructions are no longer present in the pulse library of a qobj, resulting in a key error in the pulse digest when looking up properties of instructions in the internal pulse-simulator representation of the pulse library. The bug was fixed by modifying the code that loops through instructions in an experiment to simply do nothing when a delay instruction is found.
chriseclectic
approved these changes
Dec 8, 2020
Merged
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Dec 11, 2020
* Restrict cvxpy testing to python 3.7 and 3.8 The cvxpy packaging (more specifically scs) is causing issues in CI for us because since it is incorrectly trying to install numpy from a pre-release package which does not support python 3.6. The nature of this issue is difficult to pin because it's not using pip to install numpy. Since cvxpy is only used in a single place, noise transformations, instead of trying to workaround these scs packaging issues this commit just restricts the test requirements on cvxpy to only match pytho 3.7 or 3.8. If cvxpy is not installed the noise transformation tests will now skip instead of fail. * Update tutorials skip list The tutorials repo has added some new types of tutorials for different parts of aqua. These should be skipped since they don't really exercise the aer api. This commit updates the tutorials job definition to stop running these new tutorials. * Fix delay instruction bug in pulse simulator Delay instructions are no longer present in the pulse library of a qobj, resulting in a key error in the pulse digest when looking up properties of instructions in the internal pulse-simulator representation of the pulse library. The bug was fixed by modifying the code that loops through instructions in an experiment to simply do nothing when a delay instruction is found. * fixing array comparison in config pulse simulator test * Add back noise skips that were accidently removed Co-authored-by: DanPuzzuoli <dan.puzzuoli@gmail.com>
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Dec 11, 2020
* Restrict cvxpy testing to python 3.7 and 3.8 The cvxpy packaging (more specifically scs) is causing issues in CI for us because since it is incorrectly trying to install numpy from a pre-release package which does not support python 3.6. The nature of this issue is difficult to pin because it's not using pip to install numpy. Since cvxpy is only used in a single place, noise transformations, instead of trying to workaround these scs packaging issues this commit just restricts the test requirements on cvxpy to only match pytho 3.7 or 3.8. If cvxpy is not installed the noise transformation tests will now skip instead of fail. * Update tutorials skip list The tutorials repo has added some new types of tutorials for different parts of aqua. These should be skipped since they don't really exercise the aer api. This commit updates the tutorials job definition to stop running these new tutorials. * Fix delay instruction bug in pulse simulator Delay instructions are no longer present in the pulse library of a qobj, resulting in a key error in the pulse digest when looking up properties of instructions in the internal pulse-simulator representation of the pulse library. The bug was fixed by modifying the code that loops through instructions in an experiment to simply do nothing when a delay instruction is found. * fixing array comparison in config pulse simulator test * Add back noise skips that were accidently removed Co-authored-by: DanPuzzuoli <dan.puzzuoli@gmail.com>
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Dec 11, 2020
* Restrict cvxpy testing to python 3.7 and 3.8 The cvxpy packaging (more specifically scs) is causing issues in CI for us because since it is incorrectly trying to install numpy from a pre-release package which does not support python 3.6. The nature of this issue is difficult to pin because it's not using pip to install numpy. Since cvxpy is only used in a single place, noise transformations, instead of trying to workaround these scs packaging issues this commit just restricts the test requirements on cvxpy to only match pytho 3.7 or 3.8. If cvxpy is not installed the noise transformation tests will now skip instead of fail. * Update tutorials skip list The tutorials repo has added some new types of tutorials for different parts of aqua. These should be skipped since they don't really exercise the aer api. This commit updates the tutorials job definition to stop running these new tutorials. * Fix delay instruction bug in pulse simulator Delay instructions are no longer present in the pulse library of a qobj, resulting in a key error in the pulse digest when looking up properties of instructions in the internal pulse-simulator representation of the pulse library. The bug was fixed by modifying the code that loops through instructions in an experiment to simply do nothing when a delay instruction is found. * fixing array comparison in config pulse simulator test * Add back noise skips that were accidently removed Co-authored-by: DanPuzzuoli <dan.puzzuoli@gmail.com>
chriseclectic
added
the
stable-backport-potential
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
* Restrict cvxpy testing to python 3.7 and 3.8 The cvxpy packaging (more specifically scs) is causing issues in CI for us because since it is incorrectly trying to install numpy from a pre-release package which does not support python 3.6. The nature of this issue is difficult to pin because it's not using pip to install numpy. Since cvxpy is only used in a single place, noise transformations, instead of trying to workaround these scs packaging issues this commit just restricts the test requirements on cvxpy to only match pytho 3.7 or 3.8. If cvxpy is not installed the noise transformation tests will now skip instead of fail. * Update tutorials skip list The tutorials repo has added some new types of tutorials for different parts of aqua. These should be skipped since they don't really exercise the aer api. This commit updates the tutorials job definition to stop running these new tutorials. * Fix delay instruction bug in pulse simulator Delay instructions are no longer present in the pulse library of a qobj, resulting in a key error in the pulse digest when looking up properties of instructions in the internal pulse-simulator representation of the pulse library. The bug was fixed by modifying the code that loops through instructions in an experiment to simply do nothing when a delay instruction is found. * fixing array comparison in config pulse simulator test * Add back noise skips that were accidently removed Co-authored-by: DanPuzzuoli <dan.puzzuoli@gmail.com>
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 25, 2021
* Restrict cvxpy testing to python 3.7 and 3.8 The cvxpy packaging (more specifically scs) is causing issues in CI for us because since it is incorrectly trying to install numpy from a pre-release package which does not support python 3.6. The nature of this issue is difficult to pin because it's not using pip to install numpy. Since cvxpy is only used in a single place, noise transformations, instead of trying to workaround these scs packaging issues this commit just restricts the test requirements on cvxpy to only match pytho 3.7 or 3.8. If cvxpy is not installed the noise transformation tests will now skip instead of fail. * Update tutorials skip list The tutorials repo has added some new types of tutorials for different parts of aqua. These should be skipped since they don't really exercise the aer api. This commit updates the tutorials job definition to stop running these new tutorials. * Fix delay instruction bug in pulse simulator Delay instructions are no longer present in the pulse library of a qobj, resulting in a key error in the pulse digest when looking up properties of instructions in the internal pulse-simulator representation of the pulse library. The bug was fixed by modifying the code that loops through instructions in an experiment to simply do nothing when a delay instruction is found. * fixing array comparison in config pulse simulator test * Add back noise skips that were accidently removed Co-authored-by: DanPuzzuoli <dan.puzzuoli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The cvxpy packaging (more specifically scs) is causing issues in CI for
us because since it is incorrectly trying to install numpy from a
pre-release package which does not support python 3.6. The nature of
this issue is difficult to pin because it's not using pip to install
numpy. Since cvxpy is only used in a single place, noise
transformations, instead of trying to workaround these scs packaging
issues this commit just restricts the test requirements on cvxpy to only
match pytho 3.7 or 3.8. If cvxpy is not installed the noise
transformation tests will now skip instead of fail.
Details and comments
Co-authored-by: Daniel Puzzuoli dan.puzzuoli@gmail.com