fixing Delay instruction bug in pulse simulator #1075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanPuzzuoli
requested review from
atilag,
chriseclectic and
vvilpas
as code owners
|
I'm closing this as it looks like it was already included in #1074. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay instructions are no longer present in the pulse library of a qobj, resulting in a key error in the pulse digest when looking up properties of instructions in the internal pulse-simulator representation of the pulse library. The bug was fixed by modifying the code that loops thourhg instructions in an experiment to simply do nothing when a delay instruction is found.