Adjust setup.py setup_requires to only include build dependencies #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the setup.py setup_requires field to only include build dependencies. Previously we were a bit aggresive in the set of packages we specified as build dependencies in the setup.py. This dates back to early issues building packages from sdist where things were not properly being installed. However, this results in requiring people have a working scipy (that setuptools/scikit-build) can find at build time. This commit updates the setup.py to be more explicit about the packages it requires for build time and for run time so that when users are building from source (or sdist) it is more likely to work correctly.
mtreinish
added
the
stable-backport-potential
chriseclectic
approved these changes
Sep 23, 2021
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Oct 5, 2021
…skit#1353) This commit updates the setup.py setup_requires field to only include build dependencies. Previously we were a bit aggresive in the set of packages we specified as build dependencies in the setup.py. This dates back to early issues building packages from sdist where things were not properly being installed. However, this results in requiring people have a working scipy (that setuptools/scikit-build) can find at build time. This commit updates the setup.py to be more explicit about the packages it requires for build time and for run time so that when users are building from source (or sdist) it is more likely to work correctly.
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Oct 8, 2021
…skit#1353) This commit updates the setup.py setup_requires field to only include build dependencies. Previously we were a bit aggresive in the set of packages we specified as build dependencies in the setup.py. This dates back to early issues building packages from sdist where things were not properly being installed. However, this results in requiring people have a working scipy (that setuptools/scikit-build) can find at build time. This commit updates the setup.py to be more explicit about the packages it requires for build time and for run time so that when users are building from source (or sdist) it is more likely to work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit updates the setup.py setup_requires field to only include
build dependencies. Previously we were a bit aggresive in the set of
packages we specified as build dependencies in the setup.py. This dates
back to early issues building packages from sdist where things were not
properly being installed. However, this results in requiring people have
a working scipy (that setuptools/scikit-build) can find at build time.
This commit updates the setup.py to be more explicit about the packages
it requires for build time and for run time so that when users are
building from source (or sdist) it is more likely to work correctly.
Details and comments