Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust setup.py setup_requires to only include build dependencies #1353

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Adjust setup.py setup_requires to only include build dependencies #1353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,12 @@ def install_needed_req(import_name, package_name=None, min_version=None, max_ver
# of requirements
common_requirements = [
'numpy>=1.16.3',
'scipy>=1.0',
'pybind11>=2.6' # This isn't really an install requirement,
# Pybind11 is required to be pre-installed for
# CMake to successfully find header files.
# This should be fixed in the CMake build files.
]

setup_requirements = common_requirements + [
'scikit-build>=0.11.0',
'cmake!=3.17,!=3.17.0',
'pybind11>=2.6',
]

extras_requirements = {
Expand All @@ -87,7 +83,7 @@ def install_needed_req(import_name, package_name=None, min_version=None, max_ver
if not _DISABLE_CONAN:
setup_requirements.append('conan>=1.22.2')

requirements = common_requirements + ['qiskit-terra>=0.17.0']
requirements = common_requirements + ['qiskit-terra>=0.17.0', 'scipy>=1.0']

if not hasattr(setuptools,
'find_namespace_packages') or not inspect.ismethod(
Expand Down