Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Update programId to program_id when running program #139

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Update programId to program_id when running program #139

merged 2 commits into from
Oct 18, 2021

Conversation

renier
Copy link
Collaborator

@renier renier commented Oct 8, 2021 •
edited by rathishcholarajan
Loading

Summary

We have to change the program id body parameter for the program upload
API in the Qiskti Runtime service, in order to meet the IBM Cloud API guidance.

Details and comments

Fixes #150
Are there any tests or docs here that should be updated?

The qiskit runtime api needs to update the program upload body request
419258c 
This needs to change in the program upload body request in order to
meet the IBM Cloud API guidance.
@jyu00
Copy link
Collaborator

jyu00 commented Oct 8, 2021

Are there any tests or docs here that should be updated?

No, but this change needs be ported to qiskit-ibmq-provider, since that's what we'll be using for the IEEE workshop. We'll also need to do a release of ibmq-provider.

@renier Has this been deployed to production? If not, is it possible to wait until after the workshop so we don't need to do the above?

@jyu00
Copy link
Collaborator

jyu00 commented Oct 8, 2021

Also even though the PR title says the request for program upload needs to change, your code actually changed the request for running a program. I assume the code is correct and title is wrong?

@renier renier changed the title The qiskit runtime api needs to update the program upload body request The qiskit runtime api needs to update the job run body request Oct 8, 2021
@renier
Copy link
Collaborator Author

renier commented Oct 8, 2021

@renier Has this been deployed to production? If not, is it possible to wait until after the workshop so we don't need to do the above?

It has not been deployed to production. We should talk about dates. There might be some pressure to do this earlier.

@renier
Copy link
Collaborator Author

renier commented Oct 8, 2021

Also even though the PR title says the request for program upload needs to change, your code actually changed the request for running a program. I assume the code is correct and title is wrong?

Yep, It's for running a job

@jyu00 jyu00 added the on hold Cannot fix yet label Oct 11, 2021
@jyu00
Copy link
Collaborator

jyu00 commented Oct 11, 2021

Putting this on hold until the API change is in production, which hopefully will not happen before the 20th!

@renier
Copy link
Collaborator Author

renier commented Oct 13, 2021

This is being rolled out to staging FYI. cc @rathishcholarajan

@rathishcholarajan
Copy link
Member

Thanks @renier !
FYI @kt474 .

@jyu00 jyu00 added backport potential The bug might be minimal and/or important enough to be port to stable and removed on hold Cannot fix yet labels Oct 15, 2021
@jyu00
Copy link
Collaborator

jyu00 commented Oct 18, 2021

@rathishcholarajan can you merge this to the runtime prep branch?

@rathishcholarajan rathishcholarajan changed the base branch from main to runtime-release-q4 October 18, 2021 15:14
@rathishcholarajan rathishcholarajan changed the title The qiskit runtime api needs to update the job run body request Update programId to program_id when running program Oct 18, 2021
@rathishcholarajan rathishcholarajan merged commit 31fdd4b into Qiskit:runtime-release-q4 Oct 18, 2021
@rathishcholarajan rathishcholarajan added this to the 0.1 milestone Oct 19, 2021
rathishcholarajan pushed a commit that referenced this pull request Oct 21, 2021
@renier @jyu00 @rathishcholarajan
Update programId to program_id when running program (#139)
faff4e2 
This needs to change in the program upload body request in order to
meet the IBM Cloud API guidance.

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
rathishcholarajan pushed a commit that referenced this pull request Nov 2, 2021
@renier @jyu00 @rathishcholarajan
Update programId to program_id when running program (#139)
966d42a 
This needs to change in the program upload body request in order to
meet the IBM Cloud API guidance.

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
rathishcholarajan added a commit that referenced this pull request Nov 9, 2021
@rathishcholarajan @renier
@jyu00 @kt474
Runtime release Q4 (#165)
8dffda3 
* Remove version field from runtime program (#152)

* Remove version field from runtime program

* Add release note

* Rename isPublic to is_public when creating or reading runtime programs (#155)

* Update programId to program_id when running program (#139)

This needs to change in the program upload body request in order to
meet the IBM Cloud API guidance.

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

* Add support to view program update date (#160)

* Upload runtime program using 'data' field (#157)

* Read programs from "programs" array in response (#161)

* Remove version field from runtime program (#152)

* Remove version field from runtime program

* Add release note

* Rename isPublic to is_public when creating or reading runtime programs (#155)

* Update programId to program_id when running program (#139)

This needs to change in the program upload body request in order to
meet the IBM Cloud API guidance.

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

* Add support to view program update date (#160)

* Upload runtime program using 'data' field (#157)

* Read programs from "programs" array in response (#161)

* Pass program as base64 string to update (#168)

* Accept JSON schema as program metadata (#158)

* Accept JSON schema as program metadata

* Update qiskit_ibm/runtime/ibm_runtime_service.py

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

* Pass program params as object (#171)

* Fix integration tests

* Use count to reduce one last extra call to API (#172)

* Allow updating runtime metadata in place (#188)

* update runtime metadata

* return if no data

* fix mypy

* Update releasenotes/notes/update-runtime-metadata-d2ddbcfc0d034530.yaml

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* Remove version field from runtime program (#152)

* Remove version field from runtime program

* Add release note

* Rename isPublic to is_public when creating or reading runtime programs (#155)

* Update programId to program_id when running program (#139)

This needs to change in the program upload body request in order to
meet the IBM Cloud API guidance.

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

* Add support to view program update date (#160)

* Upload runtime program using 'data' field (#157)

* Read programs from "programs" array in response (#161)

* Pass program as base64 string to update (#168)

* Accept JSON schema as program metadata (#158)

* Accept JSON schema as program metadata

* Update qiskit_ibm/runtime/ibm_runtime_service.py

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>

* Pass program params as object (#171)

* Fix integration tests

* Use count to reduce one last extra call to API (#172)

* Allow updating runtime metadata in place (#188)

* update runtime metadata

* return if no data

* fix mypy

* Update releasenotes/notes/update-runtime-metadata-d2ddbcfc0d034530.yaml

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* Allow filtering runtime jobs by program ID (#193)

* Allow filtering runtime jobs by program ID

* Fix lint

* Allow runtime program authors to retrieve program data (#174)

* retrieve program data

* refetch once if no program data

* remove unused import

* refresh program on data property

* fix lint

* Update qiskit_ibm/runtime/runtime_program.py

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* Update qiskit_ibm/runtime/runtime_program.py

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* Update qiskit_ibm/runtime/runtime_program.py

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* add test case

* add test case

* add default data constant

* add _validate_program method

* Update test/ibm/runtime/test_runtime.py

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* Update cache after updating program (#196)

* Allow filtering runtime jobs by provider (#197)

* add provider param

* split provider into hub/group/project

* add reno

* wip add test case

* fix lint/docs

* Update qiskit_ibm/runtime/ibm_runtime_service.py

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* Update releasenotes/notes/filter-jobs-by-provider-dead04faaf223840.yaml

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* refactor test cases

* remove print

* add integration test

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* Support pagination for retrieving runtime programs  (#170)

* wip add limit/offset params

* add reno

* refactor & update test case

* offset -> skip, implement refresh logic

* refresh when skip/limit not default

* Update releasenotes/notes/runtime-program-pagination-8d599ae984a5ce33.yaml

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* Update releasenotes/notes/runtime-program-pagination-8d599ae984a5ce33.yaml

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* add  to test case

* refactor refresh logic

* refactor

* fix lint

* add integration test

* update doc string

* Update qiskit_ibm/api/clients/runtime.py

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

* cleanup merge

* Apply suggestions from code review

* fix lint refactor

* Fetch all programs upfront 20 at a time and store in cache

For subsequent requests paginate and return from cache

* Fix integration test

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>
Co-authored-by: Rathish Cholarajan <Rathish.C@ibm.com>

Co-authored-by: Renier Morales <renier@users.noreply.github.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Kevin Tian <kevin.tian@ibm.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jyu00 jyu00 jyu00 approved these changes

Assignees
No one assigned
Labels
backport potential The bug might be minimal and/or important enough to be port to stable
Projects
None yet
Milestone
0.0.1
Development

Successfully merging this pull request may close these issues.

Run program update for runtime
3 participants
@renier @jyu00 @rathishcholarajan