Allow runtime program authors to retrieve program data #174

kt474 · 2021-10-21T02:04:16Z

Summary

fixes #66

switching base branch to runtime-release-q4 replaces #166

Details and comments

rathishcholarajan

This is not working as expected when I call runtime.programs() first and then call runtime.program("some_id").data, because runtime.programs() doesn't have data info and if we get a single program after that, it will return from cached programs list and the data will be empty. So you need to fetch the program data if someone tries to access the data property and if data is empty, and if it still errors then show not authorized message.

qiskit_ibm/runtime/ibm_runtime_service.py

rathishcholarajan

Fetch data from server when someone calls program.data property, if it doesn't already exist.

kt474 · 2021-10-25T20:21:45Z

Fetch data from server when someone calls program.data property, if it doesn't already exist.

Is there a way to specifically fetch data only when program.data is called? I don't see a way of doing this without forcing a refresh in the program method

rathishcholarajan · 2021-10-25T20:36:20Z

Is there a way to specifically fetch data only when program.data is called? I don't see a way of doing this without forcing a refresh in the program method

No there is no API to fetch just data. You would have to refresh the entire program object when someone does program.data.

kt474 · 2021-10-26T00:41:08Z

No there is no API to fetch just data. You would have to refresh the entire program object when someone does program.data.

But then shouldn't we just always refresh? Even if we could just refresh the whole object only when program.data was called - If a user called program.data first and then called programs only the one program would be listed (related to this comment).

rathishcholarajan

@kt474 Could you write unit tests and also rebase this branch?

qiskit_ibm/runtime/runtime_program.py

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

…t-ibm into runtime-program-data

rathishcholarajan

@kt474 I don't see any unit tests. I see just integration tests.

rathishcholarajan

@kt474 Almost there.. left just one minor suggestion..

test/ibm/runtime/test_runtime.py

…t-ibm into runtime-program-data

test/ibm/runtime/test_runtime.py

rathishcholarajan

Looks good! Thanks @kt474 !

* Remove version field from runtime program (#152) * Remove version field from runtime program * Add release note * Rename isPublic to is_public when creating or reading runtime programs (#155) * Update programId to program_id when running program (#139) This needs to change in the program upload body request in order to meet the IBM Cloud API guidance. Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> * Add support to view program update date (#160) * Upload runtime program using 'data' field (#157) * Read programs from "programs" array in response (#161) * Remove version field from runtime program (#152) * Remove version field from runtime program * Add release note * Rename isPublic to is_public when creating or reading runtime programs (#155) * Update programId to program_id when running program (#139) This needs to change in the program upload body request in order to meet the IBM Cloud API guidance. Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> * Add support to view program update date (#160) * Upload runtime program using 'data' field (#157) * Read programs from "programs" array in response (#161) * Pass program as base64 string to update (#168) * Accept JSON schema as program metadata (#158) * Accept JSON schema as program metadata * Update qiskit_ibm/runtime/ibm_runtime_service.py Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> * Pass program params as object (#171) * Fix integration tests * Use count to reduce one last extra call to API (#172) * Allow updating runtime metadata in place (#188) * update runtime metadata * return if no data * fix mypy * Update releasenotes/notes/update-runtime-metadata-d2ddbcfc0d034530.yaml Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * Remove version field from runtime program (#152) * Remove version field from runtime program * Add release note * Rename isPublic to is_public when creating or reading runtime programs (#155) * Update programId to program_id when running program (#139) This needs to change in the program upload body request in order to meet the IBM Cloud API guidance. Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> * Add support to view program update date (#160) * Upload runtime program using 'data' field (#157) * Read programs from "programs" array in response (#161) * Pass program as base64 string to update (#168) * Accept JSON schema as program metadata (#158) * Accept JSON schema as program metadata * Update qiskit_ibm/runtime/ibm_runtime_service.py Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> * Pass program params as object (#171) * Fix integration tests * Use count to reduce one last extra call to API (#172) * Allow updating runtime metadata in place (#188) * update runtime metadata * return if no data * fix mypy * Update releasenotes/notes/update-runtime-metadata-d2ddbcfc0d034530.yaml Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * Allow filtering runtime jobs by program ID (#193) * Allow filtering runtime jobs by program ID * Fix lint * Allow runtime program authors to retrieve program data (#174) * retrieve program data * refetch once if no program data * remove unused import * refresh program on data property * fix lint * Update qiskit_ibm/runtime/runtime_program.py Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * Update qiskit_ibm/runtime/runtime_program.py Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * Update qiskit_ibm/runtime/runtime_program.py Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * add test case * add test case * add default data constant * add _validate_program method * Update test/ibm/runtime/test_runtime.py Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * Update cache after updating program (#196) * Allow filtering runtime jobs by provider (#197) * add provider param * split provider into hub/group/project * add reno * wip add test case * fix lint/docs * Update qiskit_ibm/runtime/ibm_runtime_service.py Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * Update releasenotes/notes/filter-jobs-by-provider-dead04faaf223840.yaml Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * refactor test cases * remove print * add integration test Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * Support pagination for retrieving runtime programs (#170) * wip add limit/offset params * add reno * refactor & update test case * offset -> skip, implement refresh logic * refresh when skip/limit not default * Update releasenotes/notes/runtime-program-pagination-8d599ae984a5ce33.yaml Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * Update releasenotes/notes/runtime-program-pagination-8d599ae984a5ce33.yaml Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * add to test case * refactor refresh logic * refactor * fix lint * add integration test * update doc string * Update qiskit_ibm/api/clients/runtime.py Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> * cleanup merge * Apply suggestions from code review * fix lint refactor * Fetch all programs upfront 20 at a time and store in cache For subsequent requests paginate and return from cache * Fix integration test Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com> Co-authored-by: Rathish Cholarajan <Rathish.C@ibm.com> Co-authored-by: Renier Morales <renier@users.noreply.github.com> Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> Co-authored-by: Kevin Tian <kevin.tian@ibm.com>

retrieve program data

710758f

rathishcholarajan suggested changes Oct 21, 2021

View reviewed changes

refetch once if no program data

1fc3ddc

kt474 requested a review from rathishcholarajan October 21, 2021 17:40

rathishcholarajan force-pushed the runtime-release-q4 branch from 15a9d5d to ab33b52 Compare October 21, 2021 19:26

kt474 added 2 commits October 25, 2021 10:21

Merge branch 'runtime-release-q4' into runtime-program-data

8e494ed

remove unused import

117bf93

rathishcholarajan reviewed Oct 25, 2021

View reviewed changes

qiskit_ibm/runtime/ibm_runtime_service.py Outdated Show resolved Hide resolved

rathishcholarajan suggested changes Oct 25, 2021

View reviewed changes

kt474 added 3 commits October 26, 2021 15:02

refresh program on data property

dceba5a

Merge branch 'runtime-release-q4' into runtime-program-data

db9f2f3

fix lint

5f48b7d

rathishcholarajan suggested changes Nov 1, 2021

View reviewed changes

qiskit_ibm/runtime/runtime_program.py Outdated Show resolved Hide resolved

qiskit_ibm/runtime/runtime_program.py Outdated Show resolved Hide resolved

qiskit_ibm/runtime/runtime_program.py Outdated Show resolved Hide resolved

kt474 and others added 6 commits November 1, 2021 02:58

Merge branch 'runtime-release-q4' into runtime-program-data

aa5e7ad

Update qiskit_ibm/runtime/runtime_program.py

e1eb9b0

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

Update qiskit_ibm/runtime/runtime_program.py

68f2dd9

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

Update qiskit_ibm/runtime/runtime_program.py

065e5be

Co-authored-by: Rathish Cholarajan <rathishc24@gmail.com>

add test case

1244f63

Merge branch 'runtime-program-data' of https://github.com/kt474/qiski…

4a92773

…t-ibm into runtime-program-data

kt474 requested a review from rathishcholarajan November 1, 2021 17:53

rathishcholarajan added backport potential The bug might be minimal and/or important enough to be port to stable Changelog: New Feature Include in the Added section of the changelog labels Nov 2, 2021

rathishcholarajan suggested changes Nov 2, 2021

View reviewed changes

rathishcholarajan force-pushed the runtime-release-q4 branch from f8a0abb to aea236b Compare November 2, 2021 17:20

kt474 added 2 commits November 2, 2021 13:25

Merge branch 'runtime-release-q4' into runtime-program-data

5f4e33e

add test case

da817d4

kt474 requested a review from rathishcholarajan November 3, 2021 03:28

rathishcholarajan suggested changes Nov 3, 2021

View reviewed changes

test/ibm/runtime/test_runtime.py Outdated Show resolved Hide resolved

kt474 and others added 2 commits November 3, 2021 20:32

add default data constant

96d71c4

Merge branch 'runtime-release-q4' into runtime-program-data

ef9255f

rathishcholarajan suggested changes Nov 4, 2021

View reviewed changes

test/ibm/runtime/test_runtime.py Outdated Show resolved Hide resolved

kt474 added 2 commits November 4, 2021 11:29

add _validate_program method

089ed9c

Merge branch 'runtime-program-data' of https://github.com/kt474/qiski…

9f3f5fb

…t-ibm into runtime-program-data

rathishcholarajan reviewed Nov 4, 2021

View reviewed changes

test/ibm/runtime/test_runtime.py Show resolved Hide resolved

Update test/ibm/runtime/test_runtime.py

5cb64a3

rathishcholarajan approved these changes Nov 4, 2021

View reviewed changes

rathishcholarajan merged commit 8e8bcb3 into Qiskit:runtime-release-q4 Nov 4, 2021

kt474 deleted the runtime-program-data branch November 4, 2021 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow runtime program authors to retrieve program data #174

Allow runtime program authors to retrieve program data #174

kt474 commented Oct 21, 2021

rathishcholarajan left a comment

rathishcholarajan left a comment •

edited

Loading

kt474 commented Oct 25, 2021

rathishcholarajan commented Oct 25, 2021

kt474 commented Oct 26, 2021

rathishcholarajan left a comment

rathishcholarajan left a comment

rathishcholarajan left a comment

rathishcholarajan left a comment

Allow runtime program authors to retrieve program data #174

Allow runtime program authors to retrieve program data #174

Conversation

kt474 commented Oct 21, 2021

Summary

Details and comments

rathishcholarajan left a comment

Choose a reason for hiding this comment

rathishcholarajan left a comment • edited Loading

Choose a reason for hiding this comment

kt474 commented Oct 25, 2021

rathishcholarajan commented Oct 25, 2021

kt474 commented Oct 26, 2021

rathishcholarajan left a comment

Choose a reason for hiding this comment

rathishcholarajan left a comment

Choose a reason for hiding this comment

rathishcholarajan left a comment

Choose a reason for hiding this comment

rathishcholarajan left a comment

Choose a reason for hiding this comment

rathishcholarajan left a comment •

edited

Loading