-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate/fix test_cancel_running_job()
in test_job.py
#1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ob.py` for semplicity
kt474
reviewed
Aug 20, 2023
@kt474 I will fix the release notes as well |
Pull Request Test Coverage Report for Build 5918090939
💛 - Coveralls |
kt474
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @robotAstray! I think there is still an issue with the cancel()
method itself but that can be taken care of in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue described in Issue #1019,
Changes Made
- Modified thecancel
method inruntime_job.py
to handle status codes 409 and 204 as cases where job cancellation cannot be performed due to specific conditions. This ensures that the client-side status accurately reflects the server-side status.test_cancel_job_running
function to wait for the server-side status update after cancellation before performing assertions. This change ensures that the test accurately reflects the behaviour of cancelling a running job.Fixes:
Fixes a race condition in the function
test_cancel_running_job()
intest_job()
where job cancellationcannot be performed due to specific conditions. Refer to Investigate/fix
test_cancel_running_job
#1019 for more details.