Update cancel method #1038
Closed
Update cancel method #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6016014796
💛 - Coveralls |
kt474
commented
Aug 28, 2023
| if self._status != JobStatus.CANCELLED: | ||
| raise RuntimeInvalidStateError( | ||
| f"Failed to cancel job: {self._job_id} has status {self._status}" | ||
| ) |
There was a problem hiding this comment.
@merav-aharoni thoughts on this approach? Instead of manually setting this status to cancelled, we query the status from the server to check the actual status
There was a problem hiding this comment.
But i'm not sure if there's a better way - I don't like having to make another api call just to handle this relatively rare edge case where the job runs too quickly and cannot be cancelled.
kt474
changed the title
|
Closing for now, will reopen when this problem arrises again or we have a better solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
related to #1019
Details and comments
Fixes #