-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test to CI for checking docker build and tutorial notebooks #652
Conversation
Seems like the test failure is when trying to connect to the gateway service. It might be worth adding a step to dump the logs on failure... something like: - name: dump logs on failure
if: ${{ failure() }}
run: |
docker compose logs gateway
docker compose logs jupyter
... |
Co-authored-by: Paul Schweigert <paul@paulschweigert.com>
It might be worth just running the getting started notebooks in the test, as those should let us know whether the basic functionality (setting up a provider, submitting a program, getting results) is working or not. |
I see where you're coming from, but I think if we build everything, we might as well make sure all our docs will actually run for the users. This is kind of like a docker build test + a notebooks test in my mind. I'm planning on ignoring the There is also a strange ray visualization in |
.github/workflows/docker-build.yml
Outdated
run: sleep 90 | ||
- name: Test notebooks in the docker environment | ||
shell: bash | ||
run: docker exec qs-jupyter "bash" "-c" "pip install nbmake pytest && pytest --nbmake --ignore=/home/jovyan/serverless/guides/07_working_with_datasets.ipynb --ignore=/home/jovyan/serverless/examples/06_electronic_structure_problem.ipynb /home/jovyan/serverless/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will ignore two tests here.
#671 PR will handle the ESProblem notebook
#672 explains why we will ignore the dataset notebook here to start. I will follow up with @IceKhan13 about why Ray is behaving like this in CI and address this issue in a separate PR
For some reason, when I go to old commits in which this docker test pased, there is no sign of those tests being run. Kind of strange... I suppose you'll have to take my word this test passes the CI? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - kicked this test again just to see, but once it's done I think we're good to merge this
Summary
Add a test to CI for testing the jupyter build and the tutorial notebooks on pushes to main