Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to CI for checking docker build and tutorial notebooks #652

Merged
merged 30 commits into from
Jun 12, 2023
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
a4f97cb
Add a test to CI for checking docker build and tutorial notebooks
caleb-johnson Jun 7, 2023
47dbb4c
Build the images in CI rather than downloading them
caleb-johnson Jun 7, 2023
990122f
Remove comments from workflow
caleb-johnson Jun 7, 2023
56eb729
Run the containers in detached mode
caleb-johnson Jun 7, 2023
0e99a20
Merge branch 'main' into test-build-ci
caleb-johnson Jun 8, 2023
de18ff2
Sleep for a minute after running containers
caleb-johnson Jun 8, 2023
930a408
Update .github/workflows/docker-build.yml
caleb-johnson Jun 8, 2023
63b6f6f
Fix nature version
caleb-johnson Jun 8, 2023
56b7ca3
Ignore ESProblem notebook
caleb-johnson Jun 9, 2023
44210d4
unpin versions in notebook docker file
caleb-johnson Jun 9, 2023
6f2b9a4
Give containers more time to initialize
caleb-johnson Jun 9, 2023
81770d3
Reduce sleep time and comment out the ray show command that is breaki…
caleb-johnson Jun 9, 2023
f501a08
Bump up sleep time to wait on docker build
caleb-johnson Jun 9, 2023
5c7936a
Dont use ray visualize
caleb-johnson Jun 9, 2023
424cd13
Remove ESProblem notebook deps
caleb-johnson Jun 9, 2023
c16a908
re-add pyscf
caleb-johnson Jun 9, 2023
d6b3509
Remove other ray show command
caleb-johnson Jun 9, 2023
6b961bb
Bump python version
caleb-johnson Jun 9, 2023
9168dc2
Run on this PR
caleb-johnson Jun 9, 2023
4992b84
Ignore datasets notebook
caleb-johnson Jun 9, 2023
d49ebc2
full paths in ignores in pytest
caleb-johnson Jun 9, 2023
9dced4f
bump sleep time. ci intermittently failing
caleb-johnson Jun 9, 2023
72f5276
Fix pytest command
caleb-johnson Jun 9, 2023
3fa1b47
sigh
caleb-johnson Jun 9, 2023
a1a44cc
Revert unnecessary changes
caleb-johnson Jun 9, 2023
b9b905e
Turn notebook test on to show output in github
caleb-johnson Jun 9, 2023
924007a
Turn notebook test on to show output in github
caleb-johnson Jun 9, 2023
fe677e6
only run on main pushes
caleb-johnson Jun 10, 2023
373e37f
Update docker-build.yml
caleb-johnson Jun 12, 2023
ad406db
remove esproblem ignore
caleb-johnson Jun 12, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/docker-build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Docker notebook tests

on:
pull_request:
branches: [ main ]
caleb-johnson marked this conversation as resolved.
Show resolved Hide resolved

jobs:
tests:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v3
- name: Build the containers
run: docker compose -f docker-compose-dev.yml --profile jupyter build
- name: Run the jupyter profile
run: docker compose -f docker-compose-dev.yml --profile jupyter up -d
- name: Give containers time to initialize
shell: bash
run: sleep 90
- name: Test notebooks in the docker environment
shell: bash
run: docker exec qs-jupyter "bash" "-c" "pip install nbmake pytest && pytest --nbmake --ignore=/home/jovyan/serverless/guides/07_working_with_datasets.ipynb /home/jovyan/serverless/"
- name: Dump logs on failure
if: ${{ failure() }}
run: |
docker compose logs gateway
docker compose logs jupyter