-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InverseCancellation
does not run in classical blocks like CXCancellation
#13437
Comments
The fix is rather straightforward. It seems like just adding the decorator |
I am in. Please assign me. |
haimeng-zhang
added a commit
to haimeng-zhang/qiskit
that referenced
this issue
Nov 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 26, 2024
* Fix an issue that `InverseCancellation` does not run in classical blocks (#13437) * Add test functions for pass running in classical blocks. * Reformat test function file * Add a release note
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 27, 2024
* Fix an issue that `InverseCancellation` does not run in classical blocks (#13437) * Add test functions for pass running in classical blocks. * Reformat test function file * Add a release note (cherry picked from commit 6025b7c) Co-authored-by: haimeng-zhang <33587226+haimeng-zhang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
2.0.0.dev0+5de0232
What is happening?
In #11212 we decided to "stop using
CXCancellation
as part of the preset pass managers as it's been superseded byInverseCancellation
". However,CXCancellation
runs inside flow controlled blocks butInverseCancellation
does not.How can we reproduce the issue?
InverseCancellation
on itNotice that the CX outside got cancelled, but not those inside.
What should happen?
It should be like
CXCancellation
Any suggestions?
Apply
InverseCancellation
recursively inside the code blocks.The text was updated successfully, but these errors were encountered: