Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CXCancellation (deprecated in 1.1) #13426

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Nov 12, 2024

Summary

Follow up on #11937, this PR removes the pass CXCancellation, which it was deprecated in qiskit 1.1

@1ucian0 1ucian0 requested a review from a team as a code owner November 12, 2024 22:34
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@1ucian0 1ucian0 added this to the 2.0.0 milestone Nov 12, 2024
@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 12162781056

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.925%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 92.23%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 12131777933: -0.02%
Covered Lines: 79344
Relevant Lines: 89226

💛 - Coveralls

from test import QiskitTestCase # pylint: disable=wrong-import-order


class TestCXCancellation(QiskitTestCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to move this test class to test_inverse_cancellation.py and modify the tests to use InverseCancellation([CXGate])?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. Done in fe0e44c . Thanks to that, I found this: #13437

@1ucian0 1ucian0 added the on hold Can not fix yet label Nov 14, 2024
@1ucian0
Copy link
Member Author

1ucian0 commented Nov 14, 2024

Tagging as blocked by #13437

@1ucian0
Copy link
Member Author

1ucian0 commented Dec 4, 2024

removing blocker. Thanks @haimeng-zhang!

@1ucian0 1ucian0 removed the on hold Can not fix yet label Dec 4, 2024
@1ucian0 1ucian0 added the Changelog: Removal Include in the Removed section of the changelog label Dec 4, 2024
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1ucian0 1ucian0 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into Qiskit:main with commit 76e68ff Dec 5, 2024
18 checks passed
@1ucian0 1ucian0 deleted the remove/11937/1 branch December 9, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants