Fix qubit filtering in BackendV2Converter with add_delay #10015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue with the filter_faulty and add_delay flag were both set on the BackendV2Converter and convert_to_target flag. In these cases the function would incorrectly add delay operations to the faulty qubits even though they should have no operations preset on them. This commit fixes the oversight to ensure that no operations are present on a qubit if it's listed as non-operational in an input BackendProperties.
mtreinish
added
stable backport potential
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4768112309
💛 - Coveralls |
jakelishman
approved these changes
Apr 25, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
This commit fixes an issue with the filter_faulty and add_delay flag were both set on the BackendV2Converter and convert_to_target flag. In these cases the function would incorrectly add delay operations to the faulty qubits even though they should have no operations preset on them. This commit fixes the oversight to ensure that no operations are present on a qubit if it's listed as non-operational in an input BackendProperties. (cherry picked from commit f4548da)
mtreinish
added a commit
that referenced
this pull request
Apr 25, 2023
…0035) This commit fixes an issue with the filter_faulty and add_delay flag were both set on the BackendV2Converter and convert_to_target flag. In these cases the function would incorrectly add delay operations to the faulty qubits even though they should have no operations preset on them. This commit fixes the oversight to ensure that no operations are present on a qubit if it's listed as non-operational in an input BackendProperties. (cherry picked from commit f4548da) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
This commit fixes an issue with the filter_faulty and add_delay flag were both set on the BackendV2Converter and convert_to_target flag. In these cases the function would incorrectly add delay operations to the faulty qubits even though they should have no operations preset on them. This commit fixes the oversight to ensure that no operations are present on a qubit if it's listed as non-operational in an input BackendProperties.
ElePT
pushed a commit
to ElePT/qiskit-ibm-provider
that referenced
this pull request
Oct 9, 2023
…it#10015) This commit fixes an issue with the filter_faulty and add_delay flag were both set on the BackendV2Converter and convert_to_target flag. In these cases the function would incorrectly add delay operations to the faulty qubits even though they should have no operations preset on them. This commit fixes the oversight to ensure that no operations are present on a qubit if it's listed as non-operational in an input BackendProperties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes an issue with the filter_faulty and add_delay flag were both set on the BackendV2Converter and convert_to_target flag. In these cases the function would incorrectly add delay operations to the faulty qubits even though they should have no operations preset on them. This commit fixes the oversight to ensure that no operations are present on a qubit if it's listed as non-operational in an input BackendProperties.
Details and comments