Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qubit filtering in BackendV2Converter with add_delay (backport #10015) #10035

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 25, 2023

This is an automatic backport of pull request #10015 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

This commit fixes an issue with the filter_faulty and add_delay flag
were both set on the BackendV2Converter and convert_to_target flag. In
these cases the function would incorrectly add delay operations to the
faulty qubits even though they should have no operations preset on them.
This commit fixes the oversight to ensure that no operations are present
on a qubit if it's listed as non-operational in an input
BackendProperties.

(cherry picked from commit f4548da)
@mergify mergify bot requested review from a team and jyu00 as code owners April 25, 2023 17:42
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@mtreinish mtreinish enabled auto-merge April 25, 2023 18:03
@mtreinish mtreinish added this pull request to the merge queue Apr 25, 2023
Merged via the queue into stable/0.24 with commit 9551661 Apr 25, 2023
@mergify mergify bot deleted the mergify/bp/stable/0.24/pr-10015 branch April 25, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants