-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename BasicAer
to BasicProvider
and refactor interface to follow BackendV2
#11422
Merged
Merged
Changes from 31 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
23ae8b2
Rename `BasicAer` to `BasicProvider`, rename `QasmSimulatorPy` to `Ba…
ElePT dd5e5ae
Migrate `BasicSimulator` interface from `BackendV1` to `BackendV2` (w…
ElePT a1a4045
Update missing references in qiskit/examples and tests
ElePT 6baef9d
Update missing docstrings
ElePT 5049669
Add future import
ElePT f88df57
Add type
ElePT aadb549
Fix lint
ElePT 4d72a45
Merge branch 'main' into rename-basic-aer
ElePT 253d844
Avoid rebuilding target/configuration when calling property
ElePT fc84c87
Merge branch 'rename-basic-aer' of https://github.com/ElePT/qiskit-te…
ElePT d3d2911
Merge branch 'main' of https://github.com/Qiskit/qiskit into rename-b…
ElePT 04560c1
Update configuration
ElePT a36a6e6
Fix conflict
ElePT 56ecc8d
Return methods to original order
ElePT b9f97bf
Merge branch 'main' into rename-basic-aer
ElePT 084a00d
Restore template matching
ElePT 7ae48fa
Merge branch 'rename-basic-aer' of https://github.com/ElePT/qiskit-te…
ElePT 4f8ba72
Add support for target.num_qubits=None in transpiler pipeline. Set nu…
ElePT 6ca23b3
Merge from main and fix conflicts
ElePT 8525ddf
Small refactorings: apply Julien's suggestions, single out unitary ga…
ElePT 9ba3225
Merge from main, fix conflicts
ElePT 5effb80
Fix style
ElePT aae6003
Add release note
ElePT 6bd130d
Apply inline suggestions from Julien's code review
ElePT 111f101
Add suggestion from Julien's code review
ElePT dabc3a6
Merge branch 'rename-basic-aer' of https://github.com/ElePT/qiskit-te…
ElePT 17fa381
Fix lint
ElePT ce67f8f
Fix docs, test
ElePT 4aa2cb2
(Desperate) attempt to fix docs
ElePT 555b1a6
Third attempt to fix docs
ElePT cdbcd30
Merge branch 'rename-basic-aer' of https://github.com/ElePT/qiskit-te…
ElePT 3af8073
Merge from main, fix conflict
ElePT 7a55777
Remove execute from basic simulator tests
ElePT bd923b2
Merge from main, fix conflicts
ElePT a4858eb
Fix conflicts
ElePT 08805a1
Merge remove-execute, fix conflicts
ElePT e25ca42
Merge remove-execute, fix conflicts
ElePT 64e02f8
Update example docstring
ElePT 8a405eb
Apply suggestions from Matt's code review
ElePT 0c5ea74
Remove BasicProvider global instance
ElePT 2c8a0f2
Apply remaining review comments
ElePT 1e48b13
Merge from main again, fix conflicts
ElePT 4638396
Fix tests
ElePT 580df52
Update reno
ElePT 4efcbc2
Fix examples
ElePT 83b45e3
Update np random generator
ElePT 0c3c55e
Merge branch 'main' of https://github.com/Qiskit/qiskit into rename-b…
ElePT 2bfc582
Use basic simulator instead of basicaer in GenericBackendV2
ElePT 85addc3
Apply code review suggestions
ElePT 7957585
Remove unused import
mtreinish d50a2f8
Update releasenotes/notes/refactor-basicaer-to-basicprovider-e27aff9c…
ElePT 6f88d27
Update refactor-basicaer-to-basicprovider-e27aff9c8e81d26e.yaml
ElePT 10514c5
Update refactor-basicaer-to-basicprovider-e27aff9c8e81d26e.yaml
ElePT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
.. _qiskit-providers-basicprovider: | ||
|
||
.. automodule:: qiskit.providers.basic_provider | ||
:no-members: | ||
:no-inherited-members: | ||
:no-special-members: |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a case where
BackendConfiguration
could not haven_qubits
, IIRC it's a required attribute that's built into the model class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this at the beginning when the
BasicSimulator
was a bit of a hybrid between V1 and V2, and forgot to change it back. No longer used or needed.