Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate visualization to top level namespace #1878

Merged
merged 11 commits into from
Apr 4, 2019

Conversation

mtreinish
Copy link
Member

Summary

This commit moves the visualization code out of tools into it's own top
level namespace, qiskit.visualization. The visualization was a bit out
of place in the tools directory and is really it's own top level thing
at this point. However, because we declared the public visualization
interfaces stable as part of the 0.7 release we must maintain backwards
compatibility. In order to facilitate that all the public APIs are still
accessible via qiskit.tools.visualization. However, private
api/modules are not accessible off of qiskit.tools.visualization
anymore.

Details and comments

@ajavadia
Copy link
Member

ajavadia commented Mar 3, 2019

while moving these files should we also remove the leading underscores? (#1206)

Copy link
Member

@ajavadia ajavadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also move the test files from test.python.tools.visualization up one level.

@jaygambetta
Copy link
Member

yes I think we should

@ajavadia
Copy link
Member

ajavadia commented Apr 3, 2019

@mtreinish can you also remove the leading underscore from the files here as you move them?

@mtreinish mtreinish force-pushed the migrate-visualization branch from 5ef9fab to cad4291 Compare April 3, 2019 23:12
ajavadia
ajavadia previously approved these changes Apr 4, 2019
This commit moves the visualization code out of tools into it's own top
level namespace, 'qiskit.visualization'. The visualization was a bit out
of place in the tools directory and is really it's own top level thing
at this point. However, because we declared the public visualization
interfaces stable as part of the 0.7 release we must maintain backwards
compatibility. In order to facilitate that all the public APIs are still
accessible via 'qiskit.tools.visualization'. However, private
api/modules are not accessible off of 'qiskit.tools.visualization'
anymore.
Sigh pylint, raising an error for both using a wildcard import and not
using all the imports from the wild card.
@ajavadia ajavadia merged commit 11d35b2 into Qiskit:master Apr 4, 2019
@mtreinish mtreinish deleted the migrate-visualization branch April 4, 2019 22:45
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
* Migrate visualization to top level namespace

This commit moves the visualization code out of tools into it's own top
level namespace, 'qiskit.visualization'. The visualization was a bit out
of place in the tools directory and is really it's own top level thing
at this point. However, because we declared the public visualization
interfaces stable as part of the 0.7 release we must maintain backwards
compatibility. In order to facilitate that all the public APIs are still
accessible via 'qiskit.tools.visualization'. However, private
api/modules are not accessible off of 'qiskit.tools.visualization'
anymore.

* Add changelog

* Fix lint

Sigh pylint, raising an error for both using a wildcard import and not
using all the imports from the wild card.

* Rebase updates

* Move tests to match new dir structure

* Update test_visualization import per review comment

* Remove underscores from visualization modules

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants