Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ShiftFrequency instruction to pulse #4390

Merged
merged 22 commits into from
May 15, 2020
Merged

Add ShiftFrequency instruction to pulse #4390

merged 22 commits into from
May 15, 2020

Conversation

SooluThomas
Copy link
Member

@SooluThomas SooluThomas commented May 5, 2020 •
edited
Loading

Summary

Add ShiftFrequency instruction to pulse

TODO

  • Reno

lcapelluto
lcapelluto reviewed May 5, 2020
View reviewed changes
qiskit/pulse/instructions/frequency.py Outdated Show resolved Hide resolved
qiskit/pulse/instructions/frequency.py Outdated Show resolved Hide resolved
qiskit/pulse/instructions/frequency.py Outdated Show resolved Hide resolved
@lcapelluto lcapelluto self-assigned this May 5, 2020
@lcapelluto lcapelluto changed the title [WIIP] Add ShiftFrequency instruction to pulse Add ShiftFrequency instruction to pulse May 5, 2020
@lcapelluto lcapelluto marked this pull request as ready for review May 5, 2020 19:06
lcapelluto
lcapelluto previously approved these changes May 5, 2020
View reviewed changes
@SooluThomas SooluThomas assigned lcapelluto and unassigned lcapelluto May 5, 2020
taalexander
taalexander requested changes May 5, 2020
View reviewed changes
qiskit/pulse/instructions/frequency.py Outdated Show resolved Hide resolved
qiskit/pulse/instructions/frequency.py Outdated Show resolved Hide resolved
qiskit/qobj/converters/pulse_instruction.py Outdated Show resolved Hide resolved
qiskit/qobj/converters/pulse_instruction.py Outdated Show resolved Hide resolved
test/python/pulse/test_schedule.py Outdated Show resolved Hide resolved
test/python/pulse/test_schedule.py Outdated Show resolved Hide resolved
test/python/qobj/test_pulse_converter.py Outdated Show resolved Hide resolved
test/python/qobj/test_pulse_converter.py Show resolved Hide resolved
test/python/visualization/test_pulse_visualization_output.py Outdated Show resolved Hide resolved
@SooluThomas SooluThomas added the Changelog: New Feature Include in the "Added" section of the changelog label May 6, 2020
lcapelluto
lcapelluto previously approved these changes May 6, 2020
View reviewed changes
taalexander
taalexander requested changes May 8, 2020
View reviewed changes
Copy link
Contributor

@taalexander taalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change similar to #4399 and then this is ready!

test/python/qobj/test_pulse_converter.py Outdated Show resolved Hide resolved
taalexander
taalexander requested changes May 11, 2020
View reviewed changes
Copy link
Contributor

@taalexander taalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, this is almost ready just a few suggestions.

releasenotes/notes/implement-shift-frequency-46d4ea16d8be2f58.yaml Outdated Show resolved Hide resolved
releasenotes/notes/implement-shift-frequency-46d4ea16d8be2f58.yaml Outdated Show resolved Hide resolved
test/python/pulse/test_schedule.py Outdated Show resolved Hide resolved
test/python/visualization/test_pulse_visualization_output.py Outdated Show resolved Hide resolved
taalexander
taalexander previously approved these changes May 11, 2020
View reviewed changes
1ucian0
1ucian0 approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit d4bbaf6 into Qiskit:master May 15, 2020
faisaldebouni pushed a commit to faisaldebouni/qiskit-terra that referenced this pull request Aug 5, 2020
@SooluThomas @mergify
Add ShiftFrequency instruction to pulse (Qiskit#4390)
37793ad 
* Add ShiftFrequency

* Review suggestions

* Lint

* remove unwanted newlines

* lint

* add newline

* Review suggestions and bugfix

* Reno

* Hz -> GHz conversion for ShiftFrequency -> PulseQobjInstruction

* Logic fixes

* review suggestion

* review suggestions

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@1ucian0 1ucian0 added the mod: pulse Related to the Pulse module label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcapelluto lcapelluto lcapelluto approved these changes

@taalexander taalexander taalexander approved these changes

@1ucian0 1ucian0 1ucian0 approved these changes

@ajavadia ajavadia Awaiting requested review from ajavadia

@DanPuzzuoli DanPuzzuoli Awaiting requested review from DanPuzzuoli

@eggerdj eggerdj Awaiting requested review from eggerdj

@jyu00 jyu00 Awaiting requested review from jyu00

@kdk kdk Awaiting requested review from kdk

@maddy-tod maddy-tod Awaiting requested review from maddy-tod

@mtreinish mtreinish Awaiting requested review from mtreinish

@nkanazawa1989 nkanazawa1989 Awaiting requested review from nkanazawa1989

@nonhermitian nonhermitian Awaiting requested review from nonhermitian

@chriseclectic chriseclectic Awaiting requested review from chriseclectic

@ewinston ewinston Awaiting requested review from ewinston

@itoko itoko Awaiting requested review from itoko

@jaygambetta jaygambetta Awaiting requested review from jaygambetta

Assignees

@lcapelluto lcapelluto

Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: pulse Related to the Pulse module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SooluThomas @1ucian0 @taalexander @lcapelluto