Bugfix: Hz -> GHz conversion for SetFrequency -> PulseQobjInstruction #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SooluThomas
requested review from
1ucian0,
ajavadia,
chriseclectic,
DanPuzzuoli,
eggerdj,
ewinston,
itoko,
jaygambetta,
jyu00,
kdk,
lcapelluto,
maddy-tod,
mtreinish,
nkanazawa1989,
nonhermitian and
taalexander
as code owners
1 task
SooluThomas
changed the title
SooluThomas
added
Changelog: Bugfix
mtreinish
changed the title
taalexander
requested changes
May 8, 2020
There was a problem hiding this comment.
Thanks for fixing this 😄. After this small change, it should be good to go. See here for an example
taalexander
requested changes
May 11, 2020
taalexander
approved these changes
May 11, 2020
mtreinish
added a commit
that referenced
this pull request
May 15, 2020
…#4399) (#4434) * Hz -> GHz conversion for SetFrequency -> PulseQobjInstruction * Reno * Logic Fixes * Review suggestions * few more corrections Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 607bdf5) Co-authored-by: SooluThomas <soolu.elto@gmail.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
…Qiskit#4399) * Hz -> GHz conversion for SetFrequency -> PulseQobjInstruction * Reno * Logic Fixes * Review suggestions * few more corrections Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the big pointed out in the review comment:
Details and comments
SetFrequencyshould be in Hz on the frontend and has to be converted to GHz whenSetFrequencyis converted to Qobj Instruction and vice versa.