numpy>=1.17,<=1.18 #4599
Merged
numpy>=1.17,<=1.18 #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
reviewed
Jun 22, 2020
added 2 commits
June 22, 2020 15:01
mtreinish
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
This LGTM, this PR adds the relief valve for terra to land changes in the short term, but we need to get to the bottom of what changed in numpy 1.19.0. Lets open a terra issue (which may end up being a numpy issue after some debug) so we can track this and work to remove this cap (or make it a single version exclude in the setup.py
|
I opened an issue for tracking this here: #4606 we'll need to get this sorted before the next release. |
This was referenced Jul 1, 2020
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jul 7, 2020
Since Qiskit#4613 is fixed it looks like we can remove the CI pin for the latest numpy release. Failures with numpy on test_qasm_2q_unitary haven't been reproducible locally, so there shouldn't be a blocker anymore to running tests with the latest numpy release. This reverts commit 6aca34a. Fixes Qiskit#4606
1ucian0
pushed a commit
that referenced
this pull request
Jul 12, 2020
* Revert "Pin numpy version < 1.19.0 to unblock CI (#4599)" Since #4613 is fixed it looks like we can remove the CI pin for the latest numpy release. Failures with numpy on test_qasm_2q_unitary haven't been reproducible locally, so there shouldn't be a blocker anymore to running tests with the latest numpy release. This reverts commit 6aca34a. Fixes #4606 * Round result from decomp0 The root cause of the issue causing the failure on windows for 2q unitary decomposition of an identity matrix was a rounding issue. The U0r matrix being returned from decomp0() was [[1.00000000e+00+0.00000000e+00j 2.77555756e-17-2.77555756e-17j] [2.77555756e-17-2.77555756e-17j 1.00000000e+00+0.00000000e+00j]] instead of the expected [[1+0j + 0+0j] [0+0j + 1+0j]] this throws off later stages that use the decomposition result. This commit fixes this issue by rounding the output matrices from decomp0() to 13 decimal places (which is what is used for atol and rtol other places in the module) to avoid this type of rounding error. Co-authored-by: Luciano Bello <luciano.bello@ibm.com>
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
Some tests are failing recently: `test_qasm_2q_unitary` and `test_pulse_limits` It appears to be caused by the recent numpy 1.19.0 release, which was released released on June 20th 2020. This commit unblocks CI by pinning the numpy version so we can continue to make progress while investigating the cause of the issue. * numpy>=1.17,<=1.18 * constraints.txt * !=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are failing recently:
@mtreinish suggested that it could be numpy 0.19, released on June 20th. While investigating the issue, pinning the version.