fix sample pulse normalization #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taalexander
requested review from
DanPuzzuoli,
eggerdj,
nkanazawa1989 and
a team
as code owners
lcapelluto
approved these changes
Jun 25, 2020
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jul 7, 2020
Since Qiskit#4613 is fixed it looks like we can remove the CI pin for the latest numpy release. Failures with numpy on test_qasm_2q_unitary haven't been reproducible locally, so there shouldn't be a blocker anymore to running tests with the latest numpy release. This reverts commit 6aca34a. Fixes Qiskit#4606
1ucian0
pushed a commit
that referenced
this pull request
Jul 12, 2020
* Revert "Pin numpy version < 1.19.0 to unblock CI (#4599)" Since #4613 is fixed it looks like we can remove the CI pin for the latest numpy release. Failures with numpy on test_qasm_2q_unitary haven't been reproducible locally, so there shouldn't be a blocker anymore to running tests with the latest numpy release. This reverts commit 6aca34a. Fixes #4606 * Round result from decomp0 The root cause of the issue causing the failure on windows for 2q unitary decomposition of an identity matrix was a rounding issue. The U0r matrix being returned from decomp0() was [[1.00000000e+00+0.00000000e+00j 2.77555756e-17-2.77555756e-17j] [2.77555756e-17-2.77555756e-17j 1.00000000e+00+0.00000000e+00j]] instead of the expected [[1+0j + 0+0j] [0+0j + 1+0j]] this throws off later stages that use the decomposition result. This commit fixes this issue by rounding the output matrices from decomp0() to 13 decimal places (which is what is used for atol and rtol other places in the module) to avoid this type of rounding error. Co-authored-by: Luciano Bello <luciano.bello@ibm.com>
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
Co-authored-by: Luciano Bello <luciano.bello@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should partially resolve #4599. I'm not sure what changed in numpy 1.19 to cause this, but this appears to be a resolution.
Details and comments