Amplitude Estimation algorithms #5517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* accumulate -> evaluate in AE * prob to meas 1 -> prob good state
woodsp-ibm
reviewed
Jan 12, 2021
woodsp-ibm
previously approved these changes
Jan 12, 2021
stefan-woerner
previously approved these changes
Jan 12, 2021
Cryoris
added
automerge
Changelog: New Feature
mtreinish
reviewed
Jan 13, 2021
releasenotes/notes/amplitude-estimation-refactor-92dd0a2905b6fa0e.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/amplitude-estimation-refactor-92dd0a2905b6fa0e.yaml
Outdated
Show resolved
Hide resolved
Cryoris
dismissed stale reviews from stefan-woerner and woodsp-ibm
via
52dd6a2
woodsp-ibm
approved these changes
Jan 13, 2021
mtreinish
approved these changes
Jan 13, 2021
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jan 25, 2021
This commit adds a missing phase of pi to the grover operator circuit library entry. It is a backport from Qiskit#5517.
mergify bot
added a commit
that referenced
this pull request
Jan 25, 2021
… (#5673) * Fix global phase tracking around DAGCircuit.substitute_node. (#5618) * DAGCircuit.__eq__ to check .global_phase and .calibrations. * Fix BasisTranslator and Unroller global phase for substitute_node. * Update releasenotes/notes/dagcircuit-fix-substitute-node-global-phase-usage-ee05476a7d0b24c6.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Update releasenotes/notes/dagcircuit-fix-substitute-node-global-phase-usage-ee05476a7d0b24c6.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 89cd41e) * Backport global phase from #5517 on grover operator This commit adds a missing phase of pi to the grover operator circuit library entry. It is a backport from #5517. * Remove backport of phase and calibrartions check to dagcircuit eq In #5618 the dagcircuit __eq__ method was updated to also compare the global_phase and calibrations property. This was done to ensure we preserve both through a transpilation and other transforms since when we assert a circuit is equal to the expect result it will also check phase. However, this has backwards compatibility implications since comparing 2 QuantumCircuits would previously ignore global phase. This commit removes this piece from the backport and just leave the phase corrections as the backport. Co-authored-by: Kevin Krsulich <kevin.krsulich@ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
3 tasks
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* ae codes * add tests * update docstrings in result objects * add reno * fix old aqua dependencies * fix cyclic imports * try fixing windows tests no. 1 * fix test * try fixing windows attempt #2 * stefan's first comments * accumulate -> evaluate in AE * prob to meas 1 -> prob good state * stefans comments pt. 2 * fix lint & indent * add faster ae + bernoulli tests * fix > 1 qubit case * add comments * add FAE specific tests * raise error for rescale on custom q operator * play with the oracles * fix classicalregister > 1 * use correct reflection and rm X gates around oracle * fix construction of rescaled est. problem * fix phase in grover op * adjust result objects * adjust fae result object * fix minus sign and lint * rm trailing whitespaces * fix tests * fix lint * rm utf8 header * move rescale to problem, add evalschedule to MLAE * code review suggestions * state and obj.qubits not optional in estimation problem * add QAE algos to documentation * allow setting post processing and is good state to None to use default * rm quantum instance logic from interface * fix typehints for is good state * add Faster AE to reno * reset shots to user defined shots in FAE * fix doc build (hopefully) * add result classes to docs * make grover op optional in setter * rm reno -- there will be a global one Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* ae codes * add tests * update docstrings in result objects * add reno * fix old aqua dependencies * fix cyclic imports * try fixing windows tests no. 1 * fix test * try fixing windows attempt Qiskit/qiskit#2 * stefan's first comments * accumulate -> evaluate in AE * prob to meas 1 -> prob good state * stefans comments pt. 2 * fix lint & indent * add faster ae + bernoulli tests * fix > 1 qubit case * add comments * add FAE specific tests * raise error for rescale on custom q operator * play with the oracles * fix classicalregister > 1 * use correct reflection and rm X gates around oracle * fix construction of rescaled est. problem * fix phase in grover op * adjust result objects * adjust fae result object * fix minus sign and lint * rm trailing whitespaces * fix tests * fix lint * rm utf8 header * move rescale to problem, add evalschedule to MLAE * code review suggestions * state and obj.qubits not optional in estimation problem * add QAE algos to documentation * allow setting post processing and is good state to None to use default * rm quantum instance logic from interface * fix typehints for is good state * add Faster AE to reno * reset shots to user defined shots in FAE * fix doc build (hopefully) * add result classes to docs * make grover op optional in setter * rm reno -- there will be a global one Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the refactored amplitude estimation algorithms with a separated problem-algorithm workflow.
Details and comments
Add the refactored Amplitude Estimation algorithms:
AmplitudeEstimation(Brassard et al.)MaximumLikelihoodAmplitudeEstimation(Suzuki et al.)IterativeAmplitudeEstimation(Grinko et al.)FasterAmplitudeEstimation(Nakaji)The algorithms are separated from the problem-specific information, such as the A
and Q operators. This information is encapsulated in an
EstimationProblem. Each of the algorithms is thus re-usable for different problems anddifferent algorithms can easily be compared on the same problem.
The result objects are also more consistent and explicitly differ between the estimates for the amplitude (in [0,1]) and the post processed estimation.