-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScheduleBlock 3/4 - add ScheduleBlock #5854
Merged
mergify
merged 209 commits into
Qiskit:master
from
nkanazawa1989:issue-5679-3_schedule_block
Mar 31, 2021
Merged
ScheduleBlock 3/4 - add ScheduleBlock #5854
mergify
merged 209 commits into
Qiskit:master
from
nkanazawa1989:issue-5679-3_schedule_block
Mar 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com>
Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com>
Co-authored-by: Lauren Capelluto <laurencapelluto@gmail.com>
…9/qiskit-terra into issue-5679-1_schedule_block
…79-2_schedule_block
Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com>
Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com>
Co-authored-by: Thomas Alexander <thomasalexander2718@gmail.com>
taalexander
previously approved these changes
Mar 30, 2021
eggerdj
previously approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looking forward to seeing this in action.
taalexander
approved these changes
Mar 31, 2021
mtreinish
added
automerge
Changelog: New Feature
Include in the "Added" section of the changelog
labels
Mar 31, 2021
mtreinish
added
Changelog: API Change
Include in the "Changed" section of the changelog
Changelog: Deprecation
Include in "Deprecated" section of changelog
labels
Mar 31, 2021
This was referenced Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: API Change
Include in the "Changed" section of the changelog
Changelog: Deprecation
Include in "Deprecated" section of changelog
Changelog: New Feature
Include in the "Added" section of the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is 3/4 step of
ScheduleBlock
implementation #5679Details and comments
This PR adds
ScheduleBlock
representation of pulse program that coexists withSchedule
. This new representation has notion of transformation instead of the absolute instruction timet0
, which allows the pulse builder to generate a lazy scheduled program (i.e. all pulse durations can be parameterized). With this representation we can define fully parameterized pulse schedule.The output of the pulse builder is replaced with this representation in following PR. The
ScheduleBlock
should support all methods and properties currently available in theSchedule
though it doesn't have explicittimeslots
. An abstract class for bothSchedule
andScheduleBlock
is defined to remove code redundancy, and a function that convertsScheduleBlock
intoSchedule
is defined asqiskit.pulse.transforms.block_to_schedule
. This ensures full backward-compatibility for pulse program execution.TODO