deprecate qiskit.pulse.utils.deprecated_functionality in favor of qiskit.utils.deprecation.deprecate_function #8696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ucian0
requested review from
a team,
eggerdj,
nkanazawa1989 and
DanPuzzuoli
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3016916553
💛 - Coveralls |
jakelishman
previously approved these changes
Sep 7, 2022
jakelishman
approved these changes
Sep 7, 2022
jakelishman
added
Changelog: Deprecation
manoelmarques
pushed a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Sep 12, 2022
…kit.utils.deprecation.deprecate_function (Qiskit#8696) * deprecate deprecated_functionality * pylint: disable=cyclic-import * Add reno * Include Terra version in deprecation notice Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
mergify bot
added a commit
that referenced
this pull request
Sep 24, 2022
* Rewrite Amplitude Estimators with Primitives * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * fix errors * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/fae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/fae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/iae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * fix annotations * Add sampler properties * refactor evaluate_measurements * deprecate qiskit.pulse.utils.deprecated_functionality in favor of qiskit.utils.deprecation.deprecate_function (#8696) * deprecate deprecated_functionality * pylint: disable=cyclic-import * Add reno * Include Terra version in deprecation notice Co-authored-by: Jake Lishman <jake.lishman@ibm.com> * feat: support sum(LinearMixin) (#8722) * feat: support sum(LinearMixin) This enables the use of `sum(...)` for subclasses of the `LinearMixin` class. It also adds the reflective operand dunder methods `__radd__` and `__rsub__`. * Add crossreferences to release note Co-authored-by: Jake Lishman <jake.lishman@ibm.com> * set shots on fae sampler * cache circuits during estimate * Change algos estimate * Change from run_options ro options * remove circuits cache list * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/ae_utils.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * change slice * Get shots from metadata * Update qiskit/algorithms/amplitude_estimators/iae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Rearrange annotation None * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Fix deprecation msg Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: dlasecki <dal@zurich.ibm.com> Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* Rewrite Amplitude Estimators with Primitives * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * fix errors * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/fae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/fae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/iae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * fix annotations * Add sampler properties * refactor evaluate_measurements * deprecate qiskit.pulse.utils.deprecated_functionality in favor of qiskit.utils.deprecation.deprecate_function (Qiskit#8696) * deprecate deprecated_functionality * pylint: disable=cyclic-import * Add reno * Include Terra version in deprecation notice Co-authored-by: Jake Lishman <jake.lishman@ibm.com> * feat: support sum(LinearMixin) (Qiskit#8722) * feat: support sum(LinearMixin) This enables the use of `sum(...)` for subclasses of the `LinearMixin` class. It also adds the reflective operand dunder methods `__radd__` and `__rsub__`. * Add crossreferences to release note Co-authored-by: Jake Lishman <jake.lishman@ibm.com> * set shots on fae sampler * cache circuits during estimate * Change algos estimate * Change from run_options ro options * remove circuits cache list * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/ae_utils.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * change slice * Get shots from metadata * Update qiskit/algorithms/amplitude_estimators/iae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Rearrange annotation None * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Fix deprecation msg Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: dlasecki <dal@zurich.ibm.com> Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* Rewrite Amplitude Estimators with Primitives * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * fix errors * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/fae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/fae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/iae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * fix annotations * Add sampler properties * refactor evaluate_measurements * deprecate qiskit.pulse.utils.deprecated_functionality in favor of qiskit.utils.deprecation.deprecate_function (Qiskit/qiskit#8696) * deprecate deprecated_functionality * pylint: disable=cyclic-import * Add reno * Include Terra version in deprecation notice Co-authored-by: Jake Lishman <jake.lishman@ibm.com> * feat: support sum(LinearMixin) (Qiskit/qiskit#8722) * feat: support sum(LinearMixin) This enables the use of `sum(...)` for subclasses of the `LinearMixin` class. It also adds the reflective operand dunder methods `__radd__` and `__rsub__`. * Add crossreferences to release note Co-authored-by: Jake Lishman <jake.lishman@ibm.com> * set shots on fae sampler * cache circuits during estimate * Change algos estimate * Change from run_options ro options * remove circuits cache list * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/ae_utils.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * change slice * Get shots from metadata * Update qiskit/algorithms/amplitude_estimators/iae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Rearrange annotation None * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Fix deprecation msg Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: dlasecki <dal@zurich.ibm.com> Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decorator
deprecate qiskit.pulse.utils.deprecated_functionalitywas introduced in #5854 and its functionality is fully covered by the currentqiskit.utils.deprecation.deprecate_function.