-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Amplitude Estimators with Primitives #8656
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3116197228
💛 - Coveralls |
4008094
to
1077cf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments below, some of them apply to other flavors of QAE but I only commented on one occurrence, eg about treating the sampler as shot-based vs. statevector 🙂
Co-authored-by: Julien Gacon <gaconju@gmail.com>
43d066c
to
9acbd7b
Compare
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: dlasecki <dal@zurich.ibm.com>
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manoelmarques Thx, LGTM.
* Rewrite Amplitude Estimators with Primitives * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * fix errors * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/fae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/fae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/iae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * fix annotations * Add sampler properties * refactor evaluate_measurements * deprecate qiskit.pulse.utils.deprecated_functionality in favor of qiskit.utils.deprecation.deprecate_function (Qiskit#8696) * deprecate deprecated_functionality * pylint: disable=cyclic-import * Add reno * Include Terra version in deprecation notice Co-authored-by: Jake Lishman <jake.lishman@ibm.com> * feat: support sum(LinearMixin) (Qiskit#8722) * feat: support sum(LinearMixin) This enables the use of `sum(...)` for subclasses of the `LinearMixin` class. It also adds the reflective operand dunder methods `__radd__` and `__rsub__`. * Add crossreferences to release note Co-authored-by: Jake Lishman <jake.lishman@ibm.com> * set shots on fae sampler * cache circuits during estimate * Change algos estimate * Change from run_options ro options * remove circuits cache list * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/ae_utils.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * change slice * Get shots from metadata * Update qiskit/algorithms/amplitude_estimators/iae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Rearrange annotation None * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Fix deprecation msg Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: dlasecki <dal@zurich.ibm.com> Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Rewrite Amplitude Estimators with Primitives * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * fix errors * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/fae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/fae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/iae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * fix annotations * Add sampler properties * refactor evaluate_measurements * deprecate qiskit.pulse.utils.deprecated_functionality in favor of qiskit.utils.deprecation.deprecate_function (Qiskit/qiskit#8696) * deprecate deprecated_functionality * pylint: disable=cyclic-import * Add reno * Include Terra version in deprecation notice Co-authored-by: Jake Lishman <jake.lishman@ibm.com> * feat: support sum(LinearMixin) (Qiskit/qiskit#8722) * feat: support sum(LinearMixin) This enables the use of `sum(...)` for subclasses of the `LinearMixin` class. It also adds the reflective operand dunder methods `__radd__` and `__rsub__`. * Add crossreferences to release note Co-authored-by: Jake Lishman <jake.lishman@ibm.com> * set shots on fae sampler * cache circuits during estimate * Change algos estimate * Change from run_options ro options * remove circuits cache list * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Update qiskit/algorithms/amplitude_estimators/ae_utils.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * change slice * Get shots from metadata * Update qiskit/algorithms/amplitude_estimators/iae.py Co-authored-by: dlasecki <dal@zurich.ibm.com> * Rearrange annotation None * Update qiskit/algorithms/amplitude_estimators/ae.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Fix deprecation msg Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: dlasecki <dal@zurich.ibm.com> Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: Max Rossmannek <oss@zurich.ibm.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Summary
closes #8479
closes #8480
closes #8481
closes #8482
Details and comments