-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow QuantumCircuit construction with zero qubit or clbit count #6800
Merged
mergify
merged 13 commits into
Qiskit:main
from
peendebak:fix/quantumcircuit_construction2
Aug 22, 2021
Merged
Allow QuantumCircuit construction with zero qubit or clbit count #6800
mergify
merged 13 commits into
Qiskit:main
from
peendebak:fix/quantumcircuit_construction2
Aug 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eendebakpt
changed the title
[WIP] Allow quantumcircuit construction with zero classical registers (2)
Allow quantumcircuit construction with zero classical registers (2)
Jul 26, 2021
kdk
changed the title
Allow quantumcircuit construction with zero classical registers (2)
Allow QuantumCircuit construction with zero qubit or clbit count
Aug 20, 2021
kdk
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @eendebakpt , this looks good!
kdk
added
automerge
Changelog: API Change
Include in the "Changed" section of the changelog
labels
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows construction of circuits with zero registers (either quantum or classical). The construction of these circuits is convenient with algorithmically constructing circuits with varying numbers of registers.
This is a variation on #6506. For circuits with zero qubits no quantum registers are created.
Details and comments
Variation is based on comments from #6506
@kdk