Fix hard-coded sleep in run_circuits

[renier]

Summary

Fixes #7792

Since all the places where the _safe_get_job_status happen in
a context where the intended wait/sleep time is available, we can
add the argument with the value to remove the hard-coded 5 seconds.

Details and comments

This is my first time with a PR in this area. Let me know about any doc udpates
and test updates I need to do.

[coveralls]

Pull Request Test Coverage Report for Build 2078260187

• 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 83.716%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
qiskit/utils/run_circuits.py	1	3	33.33%

Totals
Change from base Build 2075078519:	0.0%
Covered Lines:	53990
Relevant Lines:	64492

---

💛 - Coveralls

[mtreinish]

Thanks for pushing this up. You need to run black to fix the lint failures tox -eblack will do this for you. See: https://github.com/Qiskit/qiskit-terra/blob/main/CONTRIBUTING.md#style-and-lint for more details.

While I think having a quick test to cover setting the wait value is respected would be useful, but the QuantumInstance code isn't that well tested (which is why there are a lot of bugs like this in my experience). So to do it you'd either have to play a lot of games with mock to force the run_circuits code to do what you want to verify we're waiting the correct duration. Or just run a algorithm tweak the wait value on the QuantumInstance constructor and assume if the result is correct your wait parameter was respected. You would need to do this on aer as a backend since the other available backend in ci from BasicAer is not async and nothing will wait for it to return. So I think just manually testing that this works is probably sufficient in this case (mostly out of apathy).

As for documentation, a quick release note probably in the fixes section would be good to just say that the QuantumInstance used at the core of algorithms in qiskit.algorithms now respects the wait parameter for sleeps while waiting for submitted jobs to return. The process for release notes is documented here: https://github.com/Qiskit/qiskit-terra/blob/main/CONTRIBUTING.md#release-notes

[manoelmarques]

Shouldn't we also decrease the wait default value from 5 seconds ? The runtime is being changed to pass 0.2 seconds but why not change it right in the QuantumInstance init also ?

[renier]

Because 5 seconds might still be a more sensible default if you are running the QuantumInstance from outside the Qiskit Runtime environment. In which case checking the job status is a different process that goes through an Internet API each time. In the Qiskit Runtime environment, that might be just checking a value in memory.

[renier]

@mtreinish thanks. added the reno note.

[renier]

@Cryoris thanks for the lint run 👍

[Cryoris]

I tested it manually and it works, thanks @renier!