Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard-coded sleep in run_circuits (backport #7793) #7860

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 1, 2022

This is an automatic backport of pull request #7793 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Fix hard-coded sleep in run_circuits

Fixes #7792

Since all the places where the `_safe_get_job_status` happen in
a context where the intended wait/sleep time is available, we can
add the argument with the value to remove the hard-coded 5 seconds.

* run black

* add reno fix note

* grammar

* revising note accuracy

* Update releasenotes/notes/fix-hard-coded-sleep-run-circuits-a1588164e61d5336.yaml

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 51d1139)
@mergify mergify bot requested review from a team, manoelmarques and woodsp-ibm as code owners April 1, 2022 16:36
@mtreinish mtreinish added Changelog: Bugfix Include in the "Fixed" section of the changelog automerge labels Apr 1, 2022
@mergify mergify bot merged commit 2dbea97 into stable/0.20 Apr 1, 2022
@mergify mergify bot deleted the mergify/bp/stable/0.20/pr-7793 branch April 1, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants