Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods and arguments in quantum_info #8510

Merged
merged 8 commits into from
Sep 1, 2022

Conversation

ikkoham
Copy link
Contributor

@ikkoham ikkoham commented Aug 10, 2022

Summary

Details and comments

@ikkoham ikkoham added Changelog: Removal Include in the Removed section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) labels Aug 10, 2022
@ikkoham ikkoham requested a review from a team as a code owner August 10, 2022 11:29
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up old deprecations, I had one question inline. Also this needs an upgrade release note documenting the removal

@coveralls
Copy link

coveralls commented Aug 10, 2022

Pull Request Test Coverage Report for Build 2969607909

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 84.148%

Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/squ.py 2 79.78%
Totals Coverage Status
Change from base Build 2967364302: -0.001%
Covered Lines: 57008
Relevant Lines: 67747

💛 - Coveralls

@ikkoham ikkoham added this to the 0.22 milestone Aug 25, 2022
@mergify mergify bot merged commit f1c5f5e into Qiskit:main Sep 1, 2022
@ikkoham ikkoham deleted the quantum-info/rm-deprecated branch October 15, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants