-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pauli_basis deprecation #8905
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this. The options shouldn't have been removed without deprecation even though it doesn't do anything after the change of the default format.
Pull Request Test Coverage Report for Build 3250465537
💛 - Coveralls |
(cherry picked from commit 8ccfda5)
Thank you. My bad. #8510 |
Summary
Fixes the removal of
pauli_list
kwarg ofpauli_basis
which broke existing code using thepauli_list=True
future compatibility on upgrade to Qiskit Terra 0.22. This kwarg has been added back to the the function with a deprecation warning instead.Details and comments