Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring surrounding whitespace #9689

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Conversation

levbishop
Copy link
Member

In an attempt both to make #9586 smaller/easier to review and to make some obvious easy fixes that are easily automated by ruff, which will be worthwhile even in the event we don't switch over to ruff from pylint I'm pulling out a few of the obvious categories of fixes.

This one is from ruff check --select=D210 --fix qiskit tools test and fixes "No whitespaces allowed surrounding docstring text" problems, with a small bit of handwork to cover a couple cases unhandled by the autofix.

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Mar 1, 2023

Pull Request Test Coverage Report for Build 4303543399

  • 64 of 64 (100.0%) changed or added relevant lines in 64 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 85.341%

Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 94.93%
src/sabre_swap/layer.rs 4 97.32%
Totals Coverage Status
Change from base Build 4303008916: 0.02%
Covered Lines: 67529
Relevant Lines: 79128

💛 - Coveralls

@jlapeyre
Copy link
Contributor

jlapeyre commented Mar 1, 2023

These PRs (eg #9690, too) will be a great help in making #9586 more manageable.

Copy link
Contributor

@jlapeyre jlapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable automerge Changelog: None Do not include in changelog labels Mar 1, 2023
@jakelishman
Copy link
Member

(Manually updated because of test failures fixed by #9691)

@mergify mergify bot merged commit f82aca8 into Qiskit:main Mar 1, 2023
mergify bot pushed a commit that referenced this pull request Mar 1, 2023
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
(cherry picked from commit f82aca8)
mergify bot added a commit that referenced this pull request Mar 1, 2023
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
(cherry picked from commit f82aca8)

Co-authored-by: Lev Bishop <18673315+levbishop@users.noreply.github.com>
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
ElePT pushed a commit to ElePT/qiskit-algorithms that referenced this pull request Jul 27, 2023
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants