More fixing extra whitespace surrounding docstrings #9707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These cases are compounded by other quirks or typos in the docstrings. Both the extra whitespace and quirks are fixed here.
jlapeyre
added
the
type: qa
Pull Request Test Coverage Report for Build 4319779086
💛 - Coveralls |
jakelishman
previously approved these changes
Mar 2, 2023
qiskit/qasm/qasmlexer.py
Outdated
| r"\"([^\\\"]|\\.)*\" " | ||
| r"\"([^\\\"]|\\.)*\"" |
There was a problem hiding this comment.
This might be dangerous, but I don't 100% know - the Python version of lex interprets docstrings, so the whitespace might be significant. (But I very much don't know.) That said, if this commit does have an effect, then I think your new form is correct anyway.
There was a problem hiding this comment.
Oh yeah, now I remember. black will insert that space again.
jakelishman
approved these changes
Mar 2, 2023
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
* Fix extra whitespace surrounding docstrings These cases are compounded by other quirks or typos in the docstrings. Both the extra whitespace and quirks are fixed here. * Prevent black from adding trailing space in docstring --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some formatting typos in some docstrings.
This is a followup to #9689. There are four cases found as follows
These cases are compounded by other quirks or typos in the docstrings. Both the extra whitespace and quirks are fixed manually here.
Summary
Details and comments