-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT - Simplify repo and workflow #15
Conversation
Remove redundant config keys
This is almost done - except for the issue with a missing dependency, it seems (see https://github.com/Quansight-Labs/jupyter-a11y-testing/runs/8156261806?check_suite_focus=true) @gabalafou, any insights on why this might be happening would be great 🙏🏽 - the dep seems to be in Affecting:
|
It was because of a difference in the way that Yarn (1.x) and NPM handle install. My fork added a So basically, when you run I don't know why there's this difference. It's stupid and frustrating, and I think now in 2022, maybe it's no longer beneficial to use Yarn over NPM, so I replaced yarn everywhere with npm. |
This should be ready for a final review and merge |
4779d98
to
d543d47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of minor comments, this PR is looking really good!
This PR introduces:
setup.cfg
andpyproject.toml
filesCloses #3
Closes #9