bump minimum panel version to 1.3.8

[pmeier]

No description provided.

[pmeier]

As of 1.3.7rc2 there two issues that prevent adoption:

• When trying to send a message, we are instantly met with an error before the message is even rendered. Here is the traceback:

  Traceback (most recent call last):
    File "/home/philip/.conda/envs/ragna-dev/lib/python3.9/site-packages/panel/chat/feed.py", line 486, in _prepare_response
      self._callback_state = CallbackState.RUNNING
    File "/home/philip/.conda/envs/ragna-dev/lib/python3.9/contextlib.py", line 126, in __exit__
      next(self.gen)
    File "/home/philip/.conda/envs/ragna-dev/lib/python3.9/site-packages/param/parameterized.py", line 307, in batch_call_watchers
      parameterized.param._batch_call_watchers()
    File "/home/philip/.conda/envs/ragna-dev/lib/python3.9/site-packages/param/parameterized.py", line 2506, in _batch_call_watchers
      self_._execute_watcher(watcher, events)
    File "/home/philip/.conda/envs/ragna-dev/lib/python3.9/site-packages/param/parameterized.py", line 2468, in _execute_watcher
      watcher.fn(*args, **kwargs)
    File "/home/philip/.conda/envs/ragna-dev/lib/python3.9/site-packages/panel/reactive.py", line 374, in _param_change
      self._apply_update(named_events, properties, model, ref)
    File "/home/philip/.conda/envs/ragna-dev/lib/python3.9/site-packages/panel/reactive.py", line 302, in _apply_update
      self._update_model(events, msg, root, model, doc, comm)
    File "/home/philip/.conda/envs/ragna-dev/lib/python3.9/site-packages/panel/layout/base.py", line 119, in _update_model
      super()._update_model(events, msg, root, model, doc, comm)
    File "/home/philip/.conda/envs/ragna-dev/lib/python3.9/site-packages/panel/reactive.py", line 623, in _update_model
      super()._update_model(events, msg, root, model, doc, comm)
    File "/home/philip/.conda/envs/ragna-dev/lib/python3.9/site-packages/panel/reactive.py", line 318, in _update_model
      model_val = getattr(model, attr)
    File "/home/philip/.conda/envs/ragna-dev/lib/python3.9/site-packages/bokeh/core/has_props.py", line 357, in __getattr__
      return super().__getattribute__(name)
  AttributeError: 'Card' object has no attribute '_callback_state'
  

  There is no mention of Ragna at all in the traceback so I guess this is coming from panel. I'll try to compile a minimal repro. Edit: See ChatInterface is broken on 1.3.7rc2 holoviz/panel#6241 Edit2: Fixed in 1.3.7rc3

• Our auth workflow is broken. This happens because for some reason the cookie we set does not show up in pn.state.cookies. However, I can confirm that the cookie is indeed there through the browser console. Plus, through randomly refreshing the page and clicking login again I sometimes get past the authentication, i.e. panel picks up on the cookie. So far I haven't found pattern.

[philippjfr]

I was not able to track down any changes that could possibly have broken the auth flow. The panel/auth module was barely touched and the same is true of any server related code.

[pmeier]

The panel/auth module was barely touched and the same is true of any server related code.

Unfortunately, we are rolling our custom auth flow. There is a refactor planned (#178), but for now we are stuck with it.

Here is the idea:

1. When hitting / we check if we find a cookie. If that is not the case, we redirect to /auth

   ragna/ragna/deploy/_ui/app.py

   Lines 66 to 67 in 61e8d5f

   	if "auth_token" not in pn.state.cookies:
   	return pn.pane.HTML("""<script>window.location.href = '/auth';</script>""")

2. On /auth we let the user sign in and if that works, we set the cookie and redirect to /

   ragna/ragna/deploy/_ui/auth_page.py

   Lines 50 to 64 in 61e8d5f

   	try:
   	authed = await self.api_wrapper.auth(
   	self.login_input.value, self.password_input.value
   	)
   	if authed:
   	# Sets the cookie on the JS side
   	self.custom_js = f""" document.cookie = "auth_token={self.api_wrapper.auth_token}; path:/"; """
   	except Exception:
   	authed = False
   	if authed:
   	# perform redirect
   	pn.state.location.param.update(reload=True, pathname="/")

So far this works fine with 1.3.7. However when we hit / the second time, pn.state.cookies still does not have the cookie we have set. But I can verify through the browser console (document.cookie) that the cookie is there.

So it seems however panel gets the cookies from the browser is somehow broken. Maybe there was a cache introduced or the like?

[pmeier]

Here is the issue that we need fixed for our auth flow: holoviz/panel#6252

[pmeier]

Fix for the cookie issue is available in holoviz/panel#6254. However, 1.3.7 was already released and thus we now need to wait for 1.3.8 before we can update.

[nenb]

LGTM!