Fix logic when looking up pn.state.curdoc #6254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5952 we refactored the
try/finally
block ofpn.state.curdoc
. However in doing so we didn't take into account that thefinally
block is always processed last and any value returned in the finally block takes precedence. We now refactor this block correctly to ensure that we always look up thecurdoc
in theContextVar
first ensuring that async callbacks return the correctcurdoc
.Fixes #6252