Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: made all .py files pep8 compliant #110

Merged
merged 1 commit into from
Jan 26, 2015
Merged

STY: made all .py files pep8 compliant #110

merged 1 commit into from
Jan 26, 2015

Conversation

sglyon
Copy link
Member

@sglyon sglyon commented Jan 26, 2015

In the examples directory I left any case of "aligned equal signs". For example, I left this

T    = 20
A0   = 100.0
A1   = 0.05
d    = 0.20
beta = 0.95

Instead of changing to

T = 20
A0 = 100.0
A1 = 0.05
d = 0.20
beta = 0.95

as pep8 would suggest. I felt that was a fairly innocent violation.

Thanks to @cc7768 for helping on this. We split up the work, but squashed into a single commit before creating the PR

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) to 93.21% when pulling 72b1d17 on pep8 into 9b60437 on master.

@jstac
Copy link
Contributor

jstac commented Jan 26, 2015

Wow, thanks guys, nice work.

You didn't change any variable names, did you? For example, matrix A changed to a? I couldn't see any such changes. I ask because the lectures might need to be changed correspondingly.

I am very pro consistency and like to be close to PEP8. The only reason I consistently violate it is to bring variable names closer to mathematical symbols --- for example, upper case for some variable names.

PS Does anyone know when the @ operator is coming to numpy? I'm really looking forward to changing all those np.dot(A, B) to A @ B

@sglyon
Copy link
Member Author

sglyon commented Jan 26, 2015

Nope, didn't change any names.

It was mostly spaces after commas, newlines before functions/methods/classes and at EOF, and making sure line length doesn't go beyond 80.

It will come with python 3.5. From the release schedule it look like it won't be official until September

jstac added a commit that referenced this pull request Jan 26, 2015
STY: made all .py files pep8 compliant
@jstac jstac merged commit 26bc87e into master Jan 26, 2015
@jstac jstac deleted the pep8 branch January 26, 2015 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants