Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for current Notebook Launcher from Datascience #93

Closed
mmcky opened this issue Mar 10, 2021 · 4 comments
Closed

Support for current Notebook Launcher from Datascience #93

mmcky opened this issue Mar 10, 2021 · 4 comments
Assignees

Comments

@mmcky
Copy link
Contributor

mmcky commented Mar 10, 2021

@AakashGfude we need to see how much of the datascience launcher could be supported at the theme layer

https://datascience.quantecon.org/python_fundamentals/control_flow.html#net-present-values-and-asset-pricing

then click on "settings" next to launch Notebook.

Please consult @DrDrij on styling if needed. Thanks.

@mmcky
Copy link
Contributor Author

mmcky commented Apr 22, 2021

@AakashGfude I have added some comments (re: design) here

QuantEcon/lecture-datascience.myst#66 (comment)

@mmcky
Copy link
Contributor Author

mmcky commented Apr 22, 2021

@AakashGfude with the subfolder path -- can it just be added to the root address that we provide through the config?

Or is the subfolder after master in the url?

@mmcky
Copy link
Contributor Author

mmcky commented May 18, 2021

@DrDrij will work on integrating the settings and launcher into the modal (as per comments on datascience linked above)

@mmcky
Copy link
Contributor Author

mmcky commented Jun 2, 2021

fixed by #130

@mmcky mmcky closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants