-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👌 IMPROVE: Refactoring and upgrading #115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 73.12% 71.64% -1.48%
==========================================
Files 2 2
Lines 227 194 -33
==========================================
- Hits 166 139 -27
+ Misses 61 55 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
thanks @AakashGfude ping me as a reviewer when this is ready for a review. |
@AakashGfude a number of styles still need to be migrated.
|
@mmcky , the above point in the netlify link looks fine in chrome, are you in safari? |
Yeah I am using @AakashGfude some additional info. If I change the Maybe we should use <script async="async" src="https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js"></script> https://docs.mathjax.org/en/latest/web/components/combined.html |
nice work on the I will need to add a note that it isn't connected to a running kernel but this is looking neat. |
true. it is not working for sphinx-book-theme as well. so we might need to target it on the parent package it seems. |
@AakashGfude this is looking good on the rebuilds. I found one small instance of that incomplete font issue. It looks like it is using |
@AakashGfude this is the case I am finding the issue still with the fonts in |
@mmcky merging this one.🚀 |
The following PR is a refactor with the following improvements/features
interact
feature of ipywidgets work with mathjax