Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Refactoring and upgrading #115

Merged
merged 16 commits into from
May 5, 2021
Merged

👌 IMPROVE: Refactoring and upgrading #115

merged 16 commits into from
May 5, 2021

Conversation

AakashGfude
Copy link
Member

@AakashGfude AakashGfude commented May 3, 2021

The following PR is a refactor with the following improvements/features

  • upgraded to mathjax v3 from v2
  • making interact feature of ipywidgets work with mathjax
  • using web-compile https://github.com/executablebooks/web-compile to minify and hash css, js files. And create theme.conf file
  • Adding tox
  • reshuffling js files, and making tippy and feather work with it.
  • style changes in right navigation menu
  • docs update

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #115 (27d12f4) into master (907074e) will decrease coverage by 1.47%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   73.12%   71.64%   -1.48%     
==========================================
  Files           2        2              
  Lines         227      194      -33     
==========================================
- Hits          166      139      -27     
+ Misses         61       55       -6     
Flag Coverage Δ
pytests 71.64% <50.00%> (-1.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quantecon_book_theme/__init__.py 65.56% <50.00%> (-2.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907074e...27d12f4. Read the comment docs.

@mmcky
Copy link
Contributor

mmcky commented May 3, 2021

thanks @AakashGfude ping me as a reviewer when this is ready for a review.

@github-actions github-actions bot temporarily deployed to commit May 4, 2021 00:31 Inactive
@github-actions github-actions bot temporarily deployed to commit May 4, 2021 01:55 Inactive
@github-actions github-actions bot temporarily deployed to commit May 4, 2021 02:16 Inactive
@github-actions github-actions bot temporarily deployed to commit May 4, 2021 02:24 Inactive
@github-actions github-actions bot temporarily deployed to commit May 4, 2021 02:29 Inactive
@AakashGfude AakashGfude requested review from mmcky and DrDrij May 4, 2021 02:32
@github-actions github-actions bot temporarily deployed to commit May 4, 2021 02:35 Inactive
@mmcky
Copy link
Contributor

mmcky commented May 4, 2021

@mmcky
Copy link
Contributor

mmcky commented May 4, 2021

@AakashGfude a number of styles still need to be migrated.

  • display math needs to be centered by default

Screen Shot 2021-05-04 at 1 14 19 pm

Screen Shot 2021-05-04 at 1 16 06 pm

@AakashGfude
Copy link
Member Author

@mmcky , the above point in the netlify link looks fine in chrome, are you in safari?
Screen Shot 2021-05-04 at 1 56 28 pm

@mmcky
Copy link
Contributor

mmcky commented May 4, 2021

@mmcky , the above point in the netlify link looks fine in chrome, are you in safari?
Screen Shot 2021-05-04 at 1 56 28 pm

Yeah I am using safari

@AakashGfude some additional info. If I change the math rendering settings from CHTML to SVG they show up ok in safari. What is CHTML?

Maybe we should use tex-mml-svg or something like that for compatibility?

<script async="async" src="https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js"></script>

https://docs.mathjax.org/en/latest/web/components/combined.html

@mmcky
Copy link
Contributor

mmcky commented May 4, 2021

nice work on the javascript fix @AakashGfude

https://6090cb92937c549956e4e108--wonderful-lalande-528d1c.netlify.app/matsuyama.html#interactive-version

I will need to add a note that it isn't connected to a running kernel but this is looking neat.

@github-actions github-actions bot temporarily deployed to commit May 4, 2021 06:33 Inactive
@github-actions github-actions bot temporarily deployed to commit May 5, 2021 00:21 Inactive
@github-actions github-actions bot temporarily deployed to commit May 5, 2021 00:22 Inactive
@AakashGfude
Copy link
Member Author

I will need to add a note that it isn't connected to a running kernel but this is looking neat.

true. it is not working for sphinx-book-theme as well. so we might need to target it on the parent package it seems.

@github-actions github-actions bot temporarily deployed to commit May 5, 2021 02:12 Inactive
@mmcky
Copy link
Contributor

mmcky commented May 5, 2021

@AakashGfude this is looking good on the rebuilds.

I found one small instance of that incomplete font issue. It looks like it is using chtml still as the default. I could only find it in one place but I will keep an eye out for that issue.

You happy to merge this and then update #100 and #93

@mmcky
Copy link
Contributor

mmcky commented May 5, 2021

@AakashGfude this is the case I am finding the issue still with the fonts in linear algebra of lecture-python.myst

Screen Shot 2021-05-05 at 12 51 18 pm

@AakashGfude
Copy link
Member Author

@mmcky merging this one.🚀

@AakashGfude AakashGfude merged commit 8c7da75 into master May 5, 2021
@mmcky mmcky deleted the refactor branch May 5, 2021 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants