-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ NEW: Advanced launch notebook button + popup #130
Conversation
* basic collapse cell functionality * collapsible code blocks * collapsible code cells javascript corrections
Codecov Report
@@ Coverage Diff @@
## private-jupyterlab #130 +/- ##
===================================================
Coverage 71.98% 71.98%
===================================================
Files 2 2
Lines 232 232
===================================================
Hits 167 167
Misses 65 65
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@DrDrij looks like the simple click through is working nicely for the programming lecture site 👍 |
Nice one @DrDrij . Looking wonderful. The only major thing left is to be able to capture the branch name specified in
and appending it to the jupyterlab URL constructed from the private input field, by adding |
@DrDrij @AakashGfude are we able to finalise this PR and hand over what we have to |
@DrDrij can this also be documented (I can help with this) but it would be good to know what the limitations are. (i.e. can you specify multiple jupyterhub sites etc.) |
@DrDrij as per QuantEcon/lecture-datascience.myst#83 (comment) this can be renamed "Notebook Launcher" I think. |
@mmcky I think the branch thing is one of the major things remaining. And needed for datascience, as their branch is |
thanks @AakashGfude I think you're right -- this flexibilty will be useful even if for |
I will merge this one to |
* private window jupyterlab * http link checking * ✨ NEW: Advanced launch notebook button + popup (#130) * adding basic functionality to add launch buttons * triggering commit * showing settings icon when multiple servers * formatting names * edits on init py * editing test fixture * class caption removed * quantecon-book-theme js is not present * adding ipynb extension * faulty pdb * subpath of the repo * adding repo subpath to colab linkl * launch buttons * repo url formatting * removed private button * removed private option for now. * test file * hiding chevron icons * url_subpath * ✨ NEW: Collapsible input code blocks (#128) * basic collapse cell functionality * collapsible code blocks * collapsible code cells javascript corrections * Styling and markup for advanced notebook launcher * Remove troubleshooting css border * CSS toolbar tweak * Logic to show launch toolbar button with popup * Tidy launch popup styles * Override pydata paragraph styles * Override pydata heading styles * Fix heading css error * Fix another heading css error * Add JS for launch popup functionality * Update launch popup functionality * Update launch popup functionality * Update launch popup functionality * Update launch popup functionality * Update launch popup functionality * Update launch popup functionality * update libsass requirement Co-authored-by: AakashGC <aakashgfude@gmail.com> Co-authored-by: AakashGC <aakashguptachoudhury@gmail.com> Co-authored-by: mmcky <mamckay@gmail.com> * adding branch * checking and adding http in private server * greying empty private field * small edits * launchNotebookLinkURL href * launchserver function edits * re adding assets Co-authored-by: DrDrij <dr.drij@gmail.com> Co-authored-by: mmcky <mamckay@gmail.com>
Replicating something similar to the launcher on the current DataScience site.
Simple + advanced launch notebook buttons.
launch.mov