Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ NEW: Advanced launch notebook button + popup #130

Merged
merged 41 commits into from
May 27, 2021

Conversation

DrDrij
Copy link
Member

@DrDrij DrDrij commented May 24, 2021

Replicating something similar to the launcher on the current DataScience site.
Simple + advanced launch notebook buttons.

launch.mov

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #130 (9f85431) into private-jupyterlab (997d3f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           private-jupyterlab     #130   +/-   ##
===================================================
  Coverage               71.98%   71.98%           
===================================================
  Files                       2        2           
  Lines                     232      232           
===================================================
  Hits                      167      167           
  Misses                     65       65           
Flag Coverage Δ
pytests 71.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997d3f3...9f85431. Read the comment docs.

@DrDrij DrDrij changed the base branch from master to private-jupyterlab May 25, 2021 05:11
@github-actions github-actions bot temporarily deployed to commit May 26, 2021 03:54 Inactive
@mmcky
Copy link
Contributor

mmcky commented May 26, 2021

@DrDrij looks like the simple click through is working nicely for the programming lecture site 👍

@mmcky mmcky requested review from AakashGfude and mmcky May 26, 2021 04:44
@mmcky mmcky changed the title Advanced launch notebook button + popup ✨ NEW: Advanced launch notebook button + popup May 26, 2021
@AakashGfude
Copy link
Member

Nice one @DrDrij . Looking wonderful. The only major thing left is to be able to capture the branch name specified in _config.yml .

html_theme_options: 
      repository_branch: main

and appending it to the jupyterlab URL constructed from the private input field, by adding &branch={branch}

@mmcky
Copy link
Contributor

mmcky commented May 27, 2021

@DrDrij @AakashGfude are we able to finalise this PR and hand over what we have to datascience. I am meeting with them tomorrow to discuss how to switch the datascience site over to be the new live site. So it would be great to have a timeline on this. Thanks.

@mmcky
Copy link
Contributor

mmcky commented May 27, 2021

@DrDrij can this also be documented (I can help with this) but it would be good to know what the limitations are. (i.e. can you specify multiple jupyterhub sites etc.)

@mmcky
Copy link
Contributor

mmcky commented May 27, 2021

@DrDrij as per QuantEcon/lecture-datascience.myst#83 (comment) this can be renamed "Notebook Launcher" I think.

@AakashGfude
Copy link
Member

AakashGfude commented May 27, 2021

@DrDrij @AakashGfude are we able to finalise this PR and hand over what we have to datascience.

@mmcky I think the branch thing is one of the major things remaining. And needed for datascience, as their branch is main and not the default we have set master.
I am happy to implement this change today, if @DrDrij is occupied :)

@mmcky
Copy link
Contributor

mmcky commented May 27, 2021

thanks @AakashGfude I think you're right -- this flexibilty will be useful even if for master/main transitions.

@AakashGfude
Copy link
Member

I will merge this one to private-jupyterlab branch.

@AakashGfude AakashGfude merged commit 4971cf6 into private-jupyterlab May 27, 2021
AakashGfude added a commit that referenced this pull request Jun 1, 2021
* private window jupyterlab

* http link checking

* ✨ NEW: Advanced launch notebook button + popup (#130)

* adding basic functionality to add launch buttons

* triggering commit

* showing settings icon when multiple servers

* formatting names

* edits on init py

* editing test fixture

* class caption removed

* quantecon-book-theme js is not present

* adding ipynb extension

* faulty pdb

* subpath of the repo

* adding repo subpath to colab linkl

* launch buttons

* repo url formatting

* removed private button

* removed private option for now.

* test file

* hiding chevron icons

* url_subpath

* ✨ NEW: Collapsible input code blocks (#128)

* basic collapse cell functionality

* collapsible code blocks

* collapsible code cells javascript corrections

* Styling and markup for advanced notebook launcher

* Remove troubleshooting css border

* CSS toolbar tweak

* Logic to show launch toolbar button with popup

* Tidy launch popup styles

* Override pydata paragraph styles

* Override pydata heading styles

* Fix heading css error

* Fix another heading css error

* Add JS for launch popup functionality

* Update launch popup functionality

* Update launch popup functionality

* Update launch popup functionality

* Update launch popup functionality

* Update launch popup functionality

* Update launch popup functionality

* update libsass requirement

Co-authored-by: AakashGC <aakashgfude@gmail.com>
Co-authored-by: AakashGC <aakashguptachoudhury@gmail.com>
Co-authored-by: mmcky <mamckay@gmail.com>

* adding branch

* checking and adding http in private server

* greying empty private field

* small edits

* launchNotebookLinkURL href

* launchserver function edits

* re adding assets

Co-authored-by: DrDrij <dr.drij@gmail.com>
Co-authored-by: mmcky <mamckay@gmail.com>
@mmcky mmcky deleted the jupyterlab branch March 15, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants