Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better bit-wrangling abstraction #113

Open
Krastanov opened this issue May 11, 2023 · 1 comment · May be fixed by #367
Open

better bit-wrangling abstraction #113

Krastanov opened this issue May 11, 2023 · 1 comment · May be fixed by #367
Labels
code quality Code that should be refactored enhancement New feature or request

Comments

@Krastanov
Copy link
Member

In many places in the code you can see

    T = eltype(xzs)
    lowbit = T(1)
    ibig = _div(T,i-1)+1
    ismall = _mod(T,i-1)
    ismallm = lowbit<<(ismall)

where ibig is the index within the array of UIntx and ismall is the bit within that UIntx. This is getting too repetitive at this point. Find a better way to write it, abstract it away.

Consult the small symbolic Cliffords (e.g. sHadamard) as they have some more abstraction.
@Krastanov Krastanov added the code quality Code that should be refactored label May 11, 2023
@Krastanov
Copy link
Member Author

@amicciche , this is related to your pull request

@Krastanov Krastanov added the enhancement New feature or request label May 13, 2023
@Fe-r-oz Fe-r-oz mentioned this issue May 6, 2024
Closed
Fe-r-oz added a commit to Fe-r-oz/QuantumClifford.jl that referenced this issue Sep 23, 2024
@Fe-r-oz
fix QuantumSavory#113 - better bit-wrangling abstraction
7d0db71
@Fe-r-oz Fe-r-oz linked a pull request Sep 23, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Code that should be refactored enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better bit-wrangling abstraction using less boilerplate Fe-r-oz/QuantumClifford.jl
1 participant
@Krastanov