Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: assertEquals -> assertEqual #615

Merged
merged 9 commits into from
Aug 24, 2024
Merged

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    763ded4 View commit details
    Browse the repository at this point in the history
  2. tests: assertEquals -> assertEqual

    The former is removed in Python 3.13
    
    QubesOS/qubes-issues#9402
    marmarek committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    c6b15f1 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. tests: wait for child process in test qubes_desktop_run

    Don't leave children, as cleanup_loop will (rightfully) detect it as a
    leak.
    marmarek committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c793ffc View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. tests: wait for child process in vm_update tests

    Don't leak child processes after the test, even if they would terminate
    after a timeout anyway.
    marmarek committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a10a0b5 View commit details
    Browse the repository at this point in the history
  2. tests: make cleanup_loop error more informative

    Include content of the selector map when it's non-empty, to ease finding
    what got leaked.
    marmarek committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c6cd538 View commit details
    Browse the repository at this point in the history
  3. tests/dispvm: fix for small resolution

    Recent Thunderbird opens a message in a window no fitting on 1024x768 by
    default. This makes the attachment button off-screen so clicking it
    doesn't work. Fix it by resizing the window.
    marmarek committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    783f6ef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7332e8f View commit details
    Browse the repository at this point in the history
  5. qubesd: use server.close_clients()

    Python 3.12+ fixed server.wait_closed() to really wait for all the
    connections to terminate. This causes qubesd to hang on shutdown, as
    events connections were not closed. Python 3.13 introduces convenient
    server.close_clients() function to close all connections.
    
    There was a similar code in tests already - convert that to
    close_clients() call too.
    
    Fixes QubesOS/qubes-issues#9427
    marmarek committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    23be00c View commit details
    Browse the repository at this point in the history
  6. qubesd: don't manually unlink the socket

    Python 3.13 adds automatic socket cleanup - specifically, a
    cleanup_socket parameter to loop.create_unix_server, and it defaults to
    True. Manual cleanup is not needed anymore.
    marmarek committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d43a12b View commit details
    Browse the repository at this point in the history