Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message if VM name starts with a character in _0123456789- #7234

Closed
DemiMarie opened this issue Feb 1, 2022 · 1 comment · Fixed by QubesOS/qubes-core-admin#606 or QubesOS/qubes-core-admin#610
Assignees
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. ux User experience

Comments

@DemiMarie
Copy link

How to file a helpful issue

Qubes OS release

R4.1

Brief summary

qvm-create _ fails with “VM name contains illegal characters”, which is misleading since _ is perfectly valid in a qube name.

Steps to reproduce

qvm-create _

Expected behavior

Better error message, such as “VM names cannot start with an underscore”

Actual behavior

Misleading error message

@DemiMarie DemiMarie added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. ux User experience P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Feb 1, 2022
@andrewdavidwong andrewdavidwong added the diagnosed Technical diagnosis has been performed (see issue comments). label Feb 1, 2022
@andrewdavidwong andrewdavidwong added this to the Release 4.1 updates milestone Feb 1, 2022
@andrewdavidwong andrewdavidwong added the affects-4.1 This issue affects Qubes OS 4.1. label Aug 8, 2023
@andrewdavidwong andrewdavidwong removed this from the Release 4.1 updates milestone Aug 13, 2023
@alimirjamali
Copy link

alimirjamali commented Jul 5, 2024

The current regex logic for VM Name validation demands alphabet for the 1st character. Thus you can not choose _*, -h, --help as VM names.

It has to be decided if the current logic is fine or has to be changed to allow underscore and other forbidden characters as 1st character. Then the code could be fixed or the issue could be closed accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. ux User experience
Projects
None yet
3 participants