Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dots in qube names #8199

Closed
marmarek opened this issue May 12, 2023 · 3 comments · Fixed by QubesOS/qubes-core-admin#540
Closed

Allow dots in qube names #8199

marmarek opened this issue May 12, 2023 · 3 comments · Fixed by QubesOS/qubes-core-admin#540
Labels
C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.

Comments

@marmarek
Copy link
Member

marmarek commented May 12, 2023 •
edited
Loading

How to file a helpful issue

The problem you're addressing (if any)

Currently allowed characters in qube names are: a-zA-Z0-9_-. Before Qubes 4.0, dot used to be allowed and that was useful thing.

The solution you'd like

Allow dots in qube names again.

The value to a user, and who that user might be

Easier to apply own naming convention to qube names.

Related: #2422
@marmarek marmarek added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels May 12, 2023
@marmarek marmarek added this to the Release 4.2 milestone May 12, 2023
@DemiMarie
Copy link

Should a leading . be allowed?

@marmarek
Copy link
Member Author

Probably no.

DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Jun 2, 2023
@DemiMarie
Allow dots in qube names
f72788d 
This is part of QubesOS/qubes-issues#8199.
@DemiMarie DemiMarie mentioned this issue Jun 2, 2023
Closed
DemiMarie added a commit to DemiMarie/qubes-core-admin that referenced this issue Jun 2, 2023
@DemiMarie
Allow dots in VM names
a031c67 
Fixes: QubesOS/qubes-issues#8199
@DemiMarie DemiMarie mentioned this issue Jun 2, 2023
Merged
DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Jun 3, 2023
@DemiMarie
Allow periods in qube names
a8f4f49 
This allows periods in qube names by using the function from
libqubes-pure to validate them instead of the built-in version.

Part of QubesOS/qubes-issues#8199.
@DemiMarie DemiMarie mentioned this issue Jun 3, 2023
Merged
DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Jun 3, 2023
@DemiMarie
Allow periods in qube names
352e964 
This uses the validation function from libqubes-pure (which permits
periods) instead of the old built-in version (which does not).

Part of QubesOS/qubes-issues#8199.
@andrewdavidwong andrewdavidwong removed this from the Release 4.2 milestone Aug 13, 2023
DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Aug 14, 2023
@DemiMarie
Allow periods in qube names
2c6f52e 
This uses the validation function from libqubes-pure (which permits
periods) instead of the old built-in version (which does not).

Part of QubesOS/qubes-issues#8199.
DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Aug 20, 2023
@DemiMarie
Allow periods in qube names
a8f61fe 
This uses the validation function from libqubes-pure (which permits
periods) instead of the old built-in version (which does not).

Part of QubesOS/qubes-issues#8199.
DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Sep 17, 2023
@DemiMarie
Allow periods in qube names
2ecf172 
This uses the validation function from libqubes-pure (which permits
periods) instead of the old built-in version (which does not).

Part of QubesOS/qubes-issues#8199.

This reverts commit 1ba8051.
@DemiMarie DemiMarie mentioned this issue Sep 17, 2023
Merged
DemiMarie added a commit to DemiMarie/qubes-gui-daemon that referenced this issue Sep 18, 2023
@DemiMarie
Allow periods in qube names
9584e3f 
This uses the validation function from libqubes-pure (which permits
periods) instead of the old built-in version (which does not).

Part of QubesOS/qubes-issues#8199.

This reverts commit 1ba8051.
This was referenced Jan 11, 2024
Closed
Closed
@marmarek marmarek moved this to In review in Current team tasks Mar 13, 2024
Closed
@qubesos-bot qubesos-bot mentioned this issue Apr 18, 2024
Closed
@alimirjamali
Copy link

Notes: Patch and Unit test for #7234 should be changed to adapt with this change.

@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label Jul 6, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Current team tasks Jul 20, 2024
@qubesos-bot qubesos-bot mentioned this issue Aug 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
Current team tasks
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow dots in VM names DemiMarie/qubes-core-admin
4 participants
@marmarek @alimirjamali @DemiMarie @andrewdavidwong