New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow beAKindOf and beAnInstanceOf to nest inside of other matchers #1173

Merged

younata merged 1 commit into main from allow_nesting_in_beakindof

Nov 5, 2024

Member

younata commented Nov 5, 2024

When you nest beAKindOf and beAnInstanceOf inside of other matchers (such as beSuccess), you get a build error.

This changes the definition of those 2 matchers to allow nesting, without otherwise changing their logic.

In my opinion, this is more of a compiler bug than anything else, but fixing it on Nimble's end is simple enough.


          Allow beAKindOf and beAnInstanceOf to nest inside of other matchers

younata merged commit 856b940 into main

13 of 16 checks passed

younata deleted the allow_nesting_in_beakindof branch

November 5, 2024 22:49

younata mentioned this pull request

Allow beIdenticalTo and be matchers to be used as composed matchers #1178

Merged

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet