Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow beIdenticalTo and be matchers to be used as composed matchers #1178

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

younata
Copy link
Member

@younata younata commented Dec 11, 2024

Because beIdenticalTo and be are typed to AnyObject, they do not build when used as a composed matcher (e.g. as part of satisfyAnyOf, or map). Which is justifiably rather frustrating.

This is a very small change with no need for documentation. I actually view this as a bugfix change.

This is very similar to what #1173 did, but now to 2 other matchers.

Checklist - While not every PR needs it, new features should consider this list:

  • Does this have tests?
  • Does this have documentation?
  • Does this break the public API (Requires major version bump)?
  • Is this a new feature (Requires minor version bump)?

@younata younata merged commit 51d5438 into main Dec 12, 2024
5 of 16 checks passed
@younata younata deleted the allow_beAnInstanceOf_and_be_as_submatchers branch December 12, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant