Make it clear that identity matchers only work with reference types #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might be obvious to an experienced Swift developer but it could catch people out (like me - see Quick#298).
| @@ -492,6 +492,9 @@ expect(actual).toNot(beIdenticalTo(expected)) | |||
| expect(actual) !== expected | |||
| ``` | |||
|
|
|||
| Its important to remember that beIdenticalTo only makes sense when comparing types with reference semantics, which have a notion of identity. In Swift, that means a `class`. This matcher will not work with types with value semantics such as `struct` or `enum`. If you need to compare two value types, you can either compare individual properties or if it makes sense to do so, make your type implement `Equatable` and use Nimble's equivalence matchers instead. | |||
There was a problem hiding this comment.
Looks good! Do you think it makes sense to have "beIdenticalTo" as "beIdenticalTo"?
There was a problem hiding this comment.
Yes, I missed that one.
|
Thanks a lot! |
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Make it clear that identity matchers only work with reference types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To clear up any confusion that might arise (see #298).